Update cluster storage modal

[pnaik1]

https://issues.redhat.com/browse/RHOAIENG-1098

Description

Refer the mock the design

Screen.Recording.2024-11-28.at.5.01.05.PM.mov

How Has This Been Tested?

Refer mocks to cover all the checks

1. Create a cluster storage and attach the existing workbench
2. Check for default mount path
3. Verify the validation path ( We are now allowing numbers)
4. create the cluster storage and check if the mountpath is correctly updated to workbench
5. Edit the existing cluster and check and change the workbench

Test Impact

Added cypress test

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pnaik1]

cc @xianli123 , I have updated the description with required screenshot

when custom path is empty, Currently I have displayed this error, let me know your thoughts around here

[codecov]

Codecov Report

Attention: Patch coverage is 87.55760% with 27 lines in your changes missing coverage. Please review.

Project coverage is 85.51%. Comparing base (a08ad68) to head (f5792f1).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
frontend/src/api/k8s/notebooks.ts	7.69%	12 Missing ⚠️
...cts/screens/detail/storage/ClusterStorageModal.tsx	91.02%	7 Missing ⚠️
.../screens/detail/storage/ClusterStorageTableRow.tsx	93.15%	5 Missing ⚠️
...src/pages/projects/screens/detail/storage/utils.ts	93.61%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3529      +/-   ##
==========================================
+ Coverage   85.42%   85.51%   +0.09%     
==========================================
  Files        1353     1342      -11     
  Lines       31129    31128       -1     
  Branches     8692     8712      +20     
==========================================
+ Hits        26591    26620      +29     
+ Misses       4538     4508      -30     

Files with missing lines	Coverage Δ
frontend/src/pages/projects/notebook/utils.ts	33.33% <100.00%> (-2.63%)	⬇️
...ojects/screens/detail/storage/BaseStorageModal.tsx	82.97% <100.00%> (+0.37%)	⬆️
...rojects/screens/detail/storage/StorageTableRow.tsx	97.36% <100.00%> (+0.22%)	⬆️
...ects/screens/detail/storage/clusterTableColumns.ts	100.00% <100.00%> (ø)
.../src/pages/projects/screens/detail/storage/data.ts	44.44% <ø> (ø)
...rc/pages/projects/screens/spawner/storage/types.ts	100.00% <100.00%> (ø)
frontend/src/pages/projects/types.ts	100.00% <ø> (ø)
...src/pages/projects/screens/detail/storage/utils.ts	90.16% <93.61%> (+11.59%)	⬆️
.../screens/detail/storage/ClusterStorageTableRow.tsx	93.15% <93.15%> (ø)
...cts/screens/detail/storage/ClusterStorageModal.tsx	92.15% <91.02%> (-2.39%)	⬇️
... and 1 more

... and 18 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ccd93...f5792f1. Read the comment docs.

[dpanshug]

There should be label ("Connected") for already connected workbenches, check here

[DaoDaoNoCode]

There is an edge case where the newly added mount path will be reset to default. Here is the step to reproduce:

1. Edit storage A which already has a workbench connection
2. Add workbench connection and edit the mount path
3. Click minus icon to remove the existing connection
4. See the newly added connection mount path is set to default, user will lose the edited value in this case

[xianli123]

Thanks @pnaik1.
I want to confirm how to trigger the popover as you shared (I attached it below). Does the 'View connection paths' trigger the popover?
A small enhancement: The bottom border of the row is missing. It will LGTM, once the border is added.

[pnaik1]

@xianli123 Thanks for the review, the popover will trigger when clicked on View connected paths , I have added the border in the latest changes

Screen.Recording.2024-12-02.at.5.32.13.PM.mov

[xianli123]

@pnaik1 Thanks for doing it! LGTM!