Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Test - Verify RHODS Explore Section Contains Only Expected ISVs #3522

Closed
wants to merge 30 commits into from

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Nov 26, 2024

https://issues.redhat.com/browse/RHOAIENG-12649

Description

Migrate ODS-1890 to cypress

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • Locally against a PSI cluster and ODH-Nightly
    image

How to run?

After exporting the test-variables.yml we have 2 different ways:

Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testExploreDefaultISVs.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/applications/explore/testExploreDefaultISVs.cy.ts" --browser chrome

Test Impact

  • This is already a test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work

antowaddle and others added 28 commits November 20, 2024 17:07
increase card timeout and delete active wait
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Nov 26, 2024
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (5627e0a) to head (b05b676).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
- Coverage   85.33%   85.32%   -0.01%     
==========================================
  Files        1354     1354              
  Lines       31110    31110              
  Branches     8687     8687              
==========================================
- Hits        26548    26545       -3     
- Misses       4562     4565       +3     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5627e0a...b05b676. Read the comment docs.

@antowaddle antowaddle closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants