-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Cypress E2E tests login to Dashboard URL with devFeatureFlags #3516
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3516 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 1354 1354
Lines 31110 31110
Branches 8687 8687
=======================================
Hits 26547 26547
Misses 4563 4563 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/__tests__/cypress/cypress/support/commands/application.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/e2e/storageClasses/storageClasses.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/support/commands/application.ts
Outdated
Show resolved
Hide resolved
22db7af
to
8893a7d
Compare
- Pass query parameters (e.g devFeatureFlags) if relative url is '/'. - Login should override the user/password values (instead of append). Signed-off-by: manosnoam <[email protected]>
8893a7d
to
f714107
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: FedeAlonso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-16164
Description
How Has This Been Tested?
All Cypress E2E tests were run using Jenkins on a real cluster (dashboard-e2e):
Test Impact
This PR enables us to run E2E on ODH Dashboard URL that includes
devFeatureFlags
in the query parameters.To use, update your ODH_DASHBOARD_URL with the desired devFeatureFlags, in the Cypress variables file (
frontend/src/__tests__/cypress/test-variables.yml
), for example:ODH_DASHBOARD_URL: https://odh-dashboard-opendatahub.apps.your-server.domain.com?devFeatureFlags=true
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main