Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cypress E2E tests login to Dashboard URL with devFeatureFlags #3516

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

manosnoam
Copy link
Contributor

@manosnoam manosnoam commented Nov 25, 2024

https://issues.redhat.com/browse/RHOAIENG-16164

Description

  • Pass query parameters (e.g devFeatureFlags) if the relative url is '/'.
  • Login should override the user/password values (instead of append).

How Has This Been Tested?

All Cypress E2E tests were run using Jenkins on a real cluster (dashboard-e2e):
image

Test Impact

This PR enables us to run E2E on ODH Dashboard URL that includes devFeatureFlags in the query parameters.
To use, update your ODH_DASHBOARD_URL with the desired devFeatureFlags, in the Cypress variables file (frontend/src/__tests__/cypress/test-variables.yml), for example:
ODH_DASHBOARD_URL: https://odh-dashboard-opendatahub.apps.your-server.domain.com?devFeatureFlags=true

Request review criteria:

Self checklist (all need to be checked):

  • [ x] The developer has manually tested the changes and verified that the changes work
  • [ x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • [x ] The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (6e4cf62) to head (fee8def).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3516   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files        1354     1354           
  Lines       31110    31110           
  Branches     8687     8687           
=======================================
  Hits        26547    26547           
  Misses       4563     4563           

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4cf62...fee8def. Read the comment docs.

- Pass query parameters (e.g devFeatureFlags) if relative url is '/'.
- Login should override the user/password values (instead of append).

Signed-off-by: manosnoam <[email protected]>
@manosnoam
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: FedeAlonso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manosnoam manosnoam merged commit 1fe5c73 into opendatahub-io:main Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants