-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Cypress - Verify users can create a workbench and connect an existent PersistentVolume #3511
test: Cypress - Verify users can create a workbench and connect an existent PersistentVolume #3511
Conversation
…istent PersistentVolume
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3511 +/- ##
=======================================
Coverage 85.31% 85.32%
=======================================
Files 1354 1354
Lines 31110 31110
Branches 8687 8687
=======================================
+ Hits 26543 26544 +1
+ Misses 4567 4566 -1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/__tests__/cypress/cypress/fixtures/resources/yaml/persistentVolumeClaim.yaml
Outdated
Show resolved
Hide resolved
...nd/src/__tests__/cypress/cypress/tests/e2e/dataScienceProjects/workbenches/workbenches.cy.ts
Outdated
Show resolved
Hide resolved
...nd/src/__tests__/cypress/cypress/tests/e2e/dataScienceProjects/workbenches/workbenches.cy.ts
Outdated
Show resolved
Hide resolved
createSpawnerPage.findSubmitButton().click(); | ||
|
||
cy.step(`Wait Workbench ${workbenchName} to have "Running" status`); | ||
const notebookRow = workbenchPage.getNotebookRow(workbenchName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reference these values also from the fixtures file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... I don't really understand what do you mean here.
notebookRow is an object, which gets selected dinamically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antowaddle if you meant 's2i-minimal-notebook' - it comes from the Dashboard UI, not from test data, so there's no need to add it to fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my comment wasn't clear. I was referring to the values below.
notebookRow.expectStatusLabelToBe('Running', 120000);
notebookRow.shouldHaveNotebookImageName('Minimal Python');
notebookRow.shouldHaveContainerSize('Small');
frontend/src/__tests__/cypress/cypress/utils/oc_commands/presistentVolumeClaim.ts
Show resolved
Hide resolved
…est/RHOAIENG-14370
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manosnoam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@FedeAlonso I tried it on dashobard-e2e cluster, and it failed on: |
https://issues.redhat.com/browse/RHOAIENG-14370
Description
Smoke migration from ODS-CI
Test: ODS-1814 : Verify User Can Create And Start A Workbench With Existent PV Storage
How Has This Been Tested?
Using a RHOAI 2.16 operator
Command:
npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/workbenches" --browser chrome
Test Impact
It's a new e2e test
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main