Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Cypress - Verify users can create a workbench and connect an existent PersistentVolume #3511

Merged

Conversation

FedeAlonso
Copy link
Contributor

@FedeAlonso FedeAlonso commented Nov 22, 2024

https://issues.redhat.com/browse/RHOAIENG-14370

Description

Smoke migration from ODS-CI
Test: ODS-1814 : Verify User Can Create And Start A Workbench With Existent PV Storage

How Has This Been Tested?

Using a RHOAI 2.16 operator
Command: npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/workbenches" --browser chrome
image

Test Impact

It's a new e2e test

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@FedeAlonso FedeAlonso marked this pull request as ready for review November 22, 2024 21:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (1fe5c73) to head (4b34981).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3511   +/-   ##
=======================================
  Coverage   85.31%   85.32%           
=======================================
  Files        1354     1354           
  Lines       31110    31110           
  Branches     8687     8687           
=======================================
+ Hits        26543    26544    +1     
+ Misses       4567     4566    -1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe5c73...4b34981. Read the comment docs.

createSpawnerPage.findSubmitButton().click();

cy.step(`Wait Workbench ${workbenchName} to have "Running" status`);
const notebookRow = workbenchPage.getNotebookRow(workbenchName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reference these values also from the fixtures file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... I don't really understand what do you mean here.
notebookRow is an object, which gets selected dinamically

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antowaddle if you meant 's2i-minimal-notebook' - it comes from the Dashboard UI, not from test data, so there's no need to add it to fixtures.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my comment wasn't clear. I was referring to the values below.

notebookRow.expectStatusLabelToBe('Running', 120000);
notebookRow.shouldHaveNotebookImageName('Minimal Python');
notebookRow.shouldHaveContainerSize('Small');

Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@manosnoam manosnoam self-requested a review November 26, 2024 08:29
@openshift-ci openshift-ci bot removed the lgtm label Nov 26, 2024
@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manosnoam manosnoam self-requested a review November 26, 2024 09:29
@manosnoam
Copy link
Contributor

@FedeAlonso I tried it on dashobard-e2e cluster, and it failed on:
AssertionError: Timed out retrying after 10000ms: Unable to find an element by: [data-testid="s2i-minimal-notebook"]
image

@openshift-merge-bot openshift-merge-bot bot merged commit 5627e0a into opendatahub-io:main Nov 26, 2024
6 checks passed
@FedeAlonso FedeAlonso deleted the test/RHOAIENG-14370 branch November 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants