-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support better handling of name and description in import pipeline modal #3508
support better handling of name and description in import pipeline modal #3508
Conversation
cc @yannnz , Can you have a look at the screenshot?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3508 +/- ##
==========================================
+ Coverage 85.22% 85.30% +0.07%
==========================================
Files 1356 1354 -2
Lines 31111 31086 -25
Branches 8681 8684 +3
==========================================
+ Hits 26514 26517 +3
+ Misses 4597 4569 -28
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Based on the new UI guideline Anges is working on, it looks like the error message is right below the field. Double check with @angesDing and @simrandhaliw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code and functionality looks good. lets just update the base component to match new UX guidelines
abb69db
to
b590435
Compare
Hi @yannnz, thank you for pointing that out. I have a question: should the name field include helper text to inform users that the name cannot be duplicated? If yes, for showing multiple helper text under a field, there is a design pattern that outlines how to display multiple helper texts underneath the field, as well as how to indicate an error status for each helper text.d as well as how to show an error status for each of helper text. |
@nding-anges I would say a system doesn't support duplicated name seems a common way in many websites. It is not that special that UI always needs to point it out. Unless we allow duplicated names in our system in other flows. |
Agreed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX feedback is addressed.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-14617
Description
The name and description for the
import pipeline/ pipeline version modal
now has a max limit of 255the submit button is disbaled if the name is duplicated
How Has This Been Tested?
import pipeline modal
with name larger character setsubmit button
is disabled with error helperTextTest Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main