-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added route configurations #3507
Conversation
Hi @olavtar. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Olga Lavtar <[email protected]>
/ok-to-test |
Please expand the existing Cypress tests to cover testing the new element. Hopefully we have good page object sharing here and this will be simple reuse. Let me know if this gets away from you. |
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
// should display the default service account name when "Model route" is checked | ||
nimDeployModal.findModelRouteCheckbox().check(); | ||
nimDeployModal.findServiceAccountNameInput().should('have.value', 'default-name'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we have a gap here -- I went ahead and logged a tech debt here. https://issues.redhat.com/browse/RHOAIENG-16190
We should definitely test more of this area -- but I don't think you need to do this as we didn't do it in KServe modal either 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/NVPE-28
Description
Added route configurations to the NIM model deployments similar to KServe.
How Has This Been Tested?
Tested to have access through the external route.
Test Impact
Tested to have access through the external route through creating a workbench.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main