Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added route configurations #3507

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

olavtar
Copy link
Contributor

@olavtar olavtar commented Nov 21, 2024

https://issues.redhat.com/browse/NVPE-28

Description

Added route configurations to the NIM model deployments similar to KServe.
image

How Has This Been Tested?

Tested to have access through the external route.

Test Impact

Tested to have access through the external route through creating a workbench.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Nov 21, 2024
@andrewballantyne
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Nov 22, 2024
@andrewballantyne
Copy link
Member

Please expand the existing Cypress tests to cover testing the new element. Hopefully we have good page object sharing here and this will be simple reuse. Let me know if this gets away from you.

@andrewballantyne andrewballantyne self-assigned this Nov 22, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Do you see this on your table in the model tab? (it's also on the overview card)

I see this after submitting the modal. No sense in having route logic if we can't use it on the flip side.


// should display the default service account name when "Model route" is checked
nimDeployModal.findModelRouteCheckbox().check();
nimDeployModal.findServiceAccountNameInput().should('have.value', 'default-name');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we have a gap here -- I went ahead and logged a tech debt here. https://issues.redhat.com/browse/RHOAIENG-16190

We should definitely test more of this area -- but I don't think you need to do this as we didn't do it in KServe modal either 😞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After successfully deploying I see this:
image

@andrewballantyne
Copy link
Member

image Do you see this on your table in the model tab? (it's also on the overview card)

I see this after submitting the modal. No sense in having route logic if we can't use it on the flip side.

I actually think this is more because the model is not deploying -- I checked a few other configurations -- and I'm having similar issues but other things are working. Let me go to the channel and see if we can get a proper deployment of a model

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2024
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6e4cf62 into opendatahub-io:main Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants