-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change token secret to have middle truncation #3505
Change token secret to have middle truncation #3505
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3505 +/- ##
==========================================
- Coverage 85.60% 85.26% -0.35%
==========================================
Files 1347 1356 +9
Lines 30704 31080 +376
Branches 8554 8660 +106
==========================================
+ Hits 26285 26500 +215
- Misses 4419 4580 +161
... and 136 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@ashley-o0o i think the tooltip is likely ok. Before the change I could scroll the input to see the full value. With the truncation and no tooltip there's no way to see the value without copying it. I suggest you keep the tooltip and have UX see it. At the very least having the tooltip remains consistent with all other truncation scenarios. |
b9e38ae
to
c82491d
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @ashley-o0o ! FWIW, PF Topology has a truncateMiddle
util which would have been awesome to use here, but it's not available for consumers to import outside of Topology.
Left a comment / suggested solution for this in patternfly/patternfly-react#10892 (comment) - looks like the PF team has prioritized this issue for the Q1 milestone 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-11861
Description
Updated token secrets to have middle truncation.
Due to PatternFly not having a true fix for this yet, I’m using our InlineTruncatedClipoardCopy.tsx work around for this fix. A few modifications added to that file to allow for middle truncation.
How Has This Been Tested?
Tested locally.
Test Impact
No new tests added
Screenshots
Before:
After:
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main