-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-11850] Updated etcd manifest #303
[RHOAIENG-11850] Updated etcd manifest #303
Conversation
4693e37
to
fec9b42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any screenshots to support the memory values?
So, I have tried this. I had to tune the
Looks like the existing resources aren't the problem, but it is the initContainer (which is the one named The PR as is is lowering the memory limits of the |
432d34b
to
b6daaf4
Compare
…et container initializer. Signed-off-by: mholder6 <[email protected]>
b6daaf4
to
828f78e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it is working correctly on my trials.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, mholder6 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updated the manifest to include requests and limits for the etcd deployment.
Tested by applying resource quota to the redhat-ods-applications project and viewing which resources did not automatically rollout after applying the rq.
After finding that the etcd deployment was the only pod that was not automatically redeployed, viewed the metrics for the etcd pod with no changes to find the request boundaries, and then added and deleted multiple ISVC's to find the limit boundaries.
Instructions to apply ResourceQuota:
Here is a copy of the RQ I used:
2 ways to apply -- CLI or UI
Using the CLI, ensure you are logged into the cluster, and using the intended project you want to apply the RQ to (in this case we are applying to the redhat-ods-applications project/namespace.
a. in the directory where you have saved the above RQ yaml, run
oc apply -f <nameOfResourceQuota.yaml>
Using the UI, there are 2 ways -- Creating a Pod or a ResourceQuota directly
Creating a Pod to create a ResourceQuota:
a. In the sidebar, navigate to Workloads, and then Pods.
b. Ensure you are in the project you want the RQ applied to. There is a drop-down list at the top left of the screen. In this case we are using the redhat-ods-applications project
c. Click the blue "Create Pod" button at the top right of the page, and paste the RQ yaml defined above.
d. Click the blue "Create" button at the bottom. -- View the ResourceQuota by navigating to the sidebar again, clicking Administration > and then Workloads.
Creating a ResourceQuota Directly:
a. In the sidebar, navigate to Administration > and then ResourceQuotas.
b. Ensure you are in the project you want the RQ applied to. There is a drop-down list at the top left of the screen. In this case we are using the redhat-ods-applications project
c. Click the blue "Create ResourceQuota" button at the top right of the page, and paste the RQ yaml defined above -- or you can manually edit the values you want for the RQ.
d. Click the blue "Create" button at the bottom.
Once the RQ is applied, modify the request and limit values to satisfy the resources in your project. The deployments that are not automatically redeployed are the deployments that do not have resource values defined.
Motivation
Modifications
Result
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags