Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kserve:main #272

Merged
merged 12 commits into from
Apr 30, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 24, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Copy link

openshift-ci bot commented Jan 24, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jooho and others added 5 commits January 24, 2024 11:19
Address DoS vulnerability in github.com/pkg/sftp

https://app.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMPKGSFTP-569475

---------

Signed-off-by: jooho <[email protected]>
Signed-off-by: Davide Salerno <[email protected]>
Co-authored-by: Signed-off-by: Davide Salerno <[email protected]>
…487)

* Rebase dev image from ubi8/go-toolset to ubi8/ubi-minimal
* Add new build stage to install Go and CLI tools that previously
  were available with the ubi/go-toolset image
* Update Go version from 1.20 to 1.21 (Dockerfile, go.mod)

---------

Signed-off-by: Christian Kadner <[email protected]>
#### Motivation

https://github.com/kserve/modelmesh-serving/security

> **Code scanning configuration error**
> CodeQL is reporting errors. Check the [tool
status](https://github.com/kserve/modelmesh-serving/security/code-scanning/tools/CodeQL/status/configurations/actions-FZTWS5DIOVRC653POJVWM3DPO5ZS6Y3PMRSXC3BOPFWWY/b3dc626bc1db336b4a359feba12ef6c0998163ba0ab6e63305c9bc82567d61c9)
for help.

<img width="683" alt="image"
src="https://github.com/kserve/modelmesh-serving/assets/12246093/d97338cd-8288-43c1-ba58-4c328780debe">


#### Modifications

- update Go version for build/test/lint workflow(s)
- update versions of (all) GitHub actions

#### Result

TBD

Signed-off-by: Christian Kadner <[email protected]>
#### Motivation
Followed the quickstart and ran into "jq not found" when running the
following command. [Quickstart
link](https://github.com/kserve/modelmesh-serving/blob/91b610bd1bcd8d5264dcd696db4e2b65730f7468/scripts/self-signed-ca.sh#L136-L139)

```./scripts/install.sh --namespace modelmesh-serving --quickstart --enable-self-signed-ca```


The following change made jq a necessary dependency:

https://github.com/kserve/modelmesh-serving/blob/91b610bd1bcd8d5264dcd696db4e2b65730f7468/scripts/self-signed-ca.sh#L136-L139

#### Modifications

Modified the list under the following link to point to where jq can be downloaded or installed https://github.com/kserve/modelmesh-serving/blob/main/docs/quickstart.md#prerequisites

#### Result
The prerequisites list has the link detailed below.

---------

Signed-off-by: medinad96 <[email protected]>
Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
Once this PR has been reviewed and has the lgtm label, please assign danielezonca for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rafvasq and others added 4 commits March 13, 2024 15:52
#### Motivation
Triton introduced [support for more model frameworks last
year](https://developer.nvidia.com/blog/real-time-serving-for-xgboost-scikit-learn-randomforest-lightgbm-and-more/)
and can support xgboost, lightgbm, and more. This PR adds examples and
docs to advertise this.

#### Modifications
- Add newly supported models to Triton runtime config, setting
`autoSelect: false`.
- Add an example ISVC config for Triton-served XGBoost model.
- Update example-models doc to reflect example models added in
kserve/modelmesh-minio-examples#7
- Update model-formats README to reflect framework support and
framework-specific docs to show example ISVC using Triton.
- Add FVTs for lightgbm and xgboost deployment on Triton runtime

#### Result
Closes #185

---------

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
This is to move away from CVE-20204-24786: infinite loop vulnerability.

Signed-off-by: Edgar Hernández <[email protected]>
#### Motivation

I'm very happy to quickly install `kserve modelmesh` by following
[quickstart](https://github.com/kserve/modelmesh-serving/blob/main/docs/quickstart.md),
but I encountered the problem when I want to write a python-based custom
`ServingRuntime` for model `mnist-svm.joblib` which is also used in many
guides and docs, and I also opened an [issue
](#494) for it.
However, I can hardly find the complete process which is available
online, including the community. So I pieced together some information
to make it's easier for user to do it.

#### Modifications

1. Add a REAMD for describing the complete process
2. Add a folder for custom ServingRuntime, including the python code,
Dockerfile and required library configuration file.

#### Result

The process for writing a python-based custom `ServingRuntime` is
completed, hope it can be a easy start for fresh user.

---------

Signed-off-by: zhlsunshine <[email protected]>
@pull pull bot added the merge-conflict Resolve conflicts manually label Apr 13, 2024
* Update kserve/kserve dependency to v0.12.0
* Update KServe CRDs to the ones in KServe v0.12.0
* Code adaptations for controller-runtime upgrade.

---------

Signed-off-by: Edgar Hernández <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Apr 17, 2024
[RHOAIENG-5305] - golang.org/x/net Allocation of Resources Without
Limits or Throttling

chore: Fixes
[CVE-2023-45288](https://www.cve.org/CVERecord?id=CVE-2023-45288)

---------

Signed-off-by: Spolti <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Apr 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1134052 into opendatahub-io:main Apr 30, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants