-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: Use DSPA custom ca cert on MLMD and Persistence Agent clients #96
UPSTREAM: <carry>: Use DSPA custom ca cert on MLMD and Persistence Agent clients #96
Conversation
Commit Checker results:
|
A set of new images have been built to help with testing out this PR: |
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-96
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-96"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-96"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-96"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-96"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-96"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/mlmd-grpc-server:latest"
envoy:
image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-96"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' Then run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/96/head
git checkout -b pullrequest df4231bfc1ea61d62c39e5f982760c581aab795d
oc apply -f dspa.pr-96.yaml More instructions here on how to deploy and test a Data Science Pipelines Application. |
Commit Checker results:
|
Change to PR detected. A new PR build was completed. |
2ba8c9c
to
bef5fa2
Compare
Commit Checker results:
|
Change to PR detected. A new PR build was completed. |
Commit Checker results:
|
Commit Checker results:
|
Change to PR detected. A new PR build was completed. |
1 similar comment
Change to PR detected. A new PR build was completed. |
0cab0a5
to
bd4acf7
Compare
Commit Checker results:
|
/lgtm |
Change to PR detected. A new PR build was completed. |
@@ -99,8 +100,8 @@ func GetMLPipelineServicePortGRPC() string { | |||
// if CA Bundle env vars are specified. | |||
func ConfigureCABundle(tmpl *wfapi.Template) { | |||
caBundleCfgMapName := os.Getenv("ARTIFACT_COPY_STEP_CABUNDLE_CONFIGMAP_NAME") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well move ARTIFACT_COPY_STEP_CABUNDLE_CONFIGMAP_NAME
to common as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Commit Checker results:
|
Commit Checker results:
|
Change to PR detected. A new PR build was completed. |
…ent clients Signed-off-by: Helber Belmiro <[email protected]>
8ed43ec
to
474c55a
Compare
Commit Checker results:
|
Change to PR detected. A new PR build was completed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
49cab50
into
opendatahub-io:master
Commit Checker results:
|
This PR must be merged with opendatahub-io/data-science-pipelines-operator#736.
Resolves https://issues.redhat.com/browse/RHOAIENG-13871
Description of your changes:
This PR adds validation of MLMD and Persistence Agent server certificates against CA in the clients.
Checklist: