Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP [do-not-merge] test rebasing to 2.2.0 #77

Closed
wants to merge 230 commits into from
Closed

WIP [do-not-merge] test rebasing to 2.2.0 #77

wants to merge 230 commits into from

Conversation

rimolive
Copy link

Description of your changes:

Checklist:

TheMichaelHu and others added 30 commits December 14, 2023 14:25
@TheMichaelHu
feat(components): Add better docstrings for AutoSxS
9f8495d 
PiperOrigin-RevId: 591051675
test(components): INTERNAL
75ffbf9 
PiperOrigin-RevId: 591075392
@connor-mccarthy
feat(sdk): add subprocess task handler #localexecution (kubeflow#10302)
21f8e9c 
* add subprocess task handler

* response to review feedback
fix(components): Use large_model_reference as `model_reference_name…
f51a930 
…` when uploading models from `preview.llm.rlhf_pipeline` instead of hardcoding value as `text-bison@001`

PiperOrigin-RevId: 591346782
@connor-mccarthy
test(sdk): add kfp-kubernetes execution tests (kubeflow#10304)
2009dfb
fix(components): Resolve unique model display name on each `preview.l…
075d58f 
…lm.rlhf_pipeline` run instead of reusing cached result

PiperOrigin-RevId: 591365087
fix(components): Upload the tuned adapter to Model Registry instead o…
2e2ba9e 
…f model checkpoint from `preview.llm.rlhf_pipeline`

PiperOrigin-RevId: 591393116
@connor-mccarthy
feat(sdk): add local execution output collection #localexecution (kub…
76aad8b 
…eflow#10325)

* feat(sdk): add local execution output collection #localexecution

* update ExecutorInput processing

* address review feedback

* fix exception handling test
@connor-mccarthy
chore(sdk): fix use of invalid escape sequence in tests (kubeflow#10310)
d0da0ad
@connor-mccarthy
feat(sdk): add local execution logging #localexecution (kubeflow#10326)
7849272
chore(components): Fix argument description
8eddc27 
PiperOrigin-RevId: 592033936
@TobiasGoerke
feat(backend): preserve querystring in pipeline root (fixes kubeflow#…
9a30612 
…10318) (kubeflow#10319)

* feat: preserve querystring in pipeline root

* refactor: create AppendToPipelineRoot
Also apply to client.go

* feat: remove query string from URIs (#1)

* feat: remove query string from URIs

* refactor(GenerateOutputURI): move and preserve comments
feat(components): change output format to allow possible post eval
44f9992 
PiperOrigin-RevId: 592257929
@zijianjoy
fix(frontend): Add disableParsingRawHTML option for markdown-to-jsx c…
c6acac9 
…omponent (kubeflow#10315)
@connor-mccarthy
feat(sdk): add DockerRunner #localexecution (kubeflow#10328)
adc5b3b
@connor-mccarthy
feat(sdk): add special dsl.OutputPath read logic #localexecution (k…
654bbde 
…ubeflow#10334)
@connor-mccarthy
chore(sdk): write local execution logs to stdout #localexecution (kub…
f52ba56 
…eflow#10330)
@connor-mccarthy
feat(sdk): support local Container Component execution #localexecution (
846f887 
kubeflow#10333)

* support Container Components

* address review feedback
@TheMichaelHu
No public description
14de087 
PiperOrigin-RevId: 592702825
feat(components): Output errors as a separate table from Arbiter
a66c599 
PiperOrigin-RevId: 592769441
@TheMichaelHu
docs(components): Fix AutoSxS docstring formatting
216d3f8 
PiperOrigin-RevId: 594058915
@connor-mccarthy
chore(components): add json_escape placeholder util
973610b 
PiperOrigin-RevId: 595174285
@connor-mccarthy
fix(sdk): fix presentation of strings in local execution #localexecut…
89d4234 
…ion (kubeflow#10353)
@connor-mccarthy
fix(sdk): remove redundant newline character in local DockerRunner …
86b7e23 
…logs (kubeflow#10354)
@connor-mccarthy
test(sdk): improve KFP SDK local runner test safety #localexecution (k…
dcab051 
…ubeflow#10336)
@DharmitD
feat(backend): Enable logging for KFP components (kubeflow#10288)
5399585
@connor-mccarthy
feat(sdk): remove local execution feature flag #localexecution (kubef…
8a5a17e 
…low#10355)
@connor-mccarthy
fix(sdk): permit empty local execution outputs #localexecution (kubef…
64d46df 
…low#10338)
@connor-mccarthy
feat(sdk): support Concat and IfPresent placeholder in local containe…
2897a10 
…r component execution #localexecution (kubeflow#10348)

* feat(sdk): support Concat and IfPresent placeholder in local container component execution #localexecution

* address review feedback

* fix test
@connor-mccarthy
test(sdk): add test for local execution of None default parameter #…
ca5f97d 
…localexecution (kubeflow#10339)
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...a80922deca6cfd9cc7a96ad4ec6b492799f18693

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...38c301c6f00beb1fe4e3b19d9655c5e3b98e0176

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...355e12be5bc40a6df9596e8d5d2ad0b16108a10b

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...e146cce7c02d56fedf0b9dc75d92ad7fa79f8936

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...6ba624fc481f760c223a9b58ba3adbb95c4abcb9

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...ba78fe935e08c6451719afc58dce321b63093517

@HumairAK
Copy link

/hold

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...5ef7e96588b0d54d0c9be41919f597e3029c93fe

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...c0fff5cc177957eb9ed2b55aad49feba0e2afc7b

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...f461d05b9708b05e4873c5539b3344f46df10ffb

@rimolive
Merge tag '2.2.0' into test-rebase
d16ee62 
Kubeflow Pipelines 2.2.0 release

Signed-off-by: Ricardo M. Oliveira <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rimolive. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 30, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the opendatahub-io org. You can then trigger verification by writing /verify-owners in a comment.

  • Tomcli
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • backend/OWNERS

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...d16ee62a91c735453e1133bf241f69bd55d63b15

@rimolive rimolive closed this Aug 30, 2024
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...d16ee62a91c735453e1133bf241f69bd55d63b15

@rimolive rimolive deleted the test-rebase branch August 30, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

@VaniHaripriya VaniHaripriya Awaiting requested review from VaniHaripriya

@HumairAK HumairAK Awaiting requested review from HumairAK

@hbelmiro hbelmiro Awaiting requested review from hbelmiro

@gmfrasca gmfrasca Awaiting requested review from gmfrasca

Assignees
No one assigned
Labels
do-not-merge/hold do-not-merge/invalid-owners-file do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.