UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server #72

hbelmiro · 2024-08-13T20:29:23Z

Resolves: https://issues.redhat.com/browse/RHOAIENG-4971

Dependent PR:

Added support for TLS to MLMD GRPC Server data-science-pipelines-operator#683

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

dsp-developers · 2024-08-13T20:39:01Z

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-72
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-72
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-72
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-72

dsp-developers · 2024-08-13T20:39:02Z

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-72.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-72
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-72"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-72"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-72"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-72"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/72/head
git checkout -b pullrequest e90d66d70ab0e7f7a69cf46f1850c41434793c5c
oc apply -f dspa.pr-72.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers · 2024-08-30T19:04:31Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...a6f385c246c19054e5306725a0b21906eb2253ce

dsp-developers · 2024-08-30T19:13:29Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-72
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-72
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-72
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-72

VaniHaripriya · 2024-09-04T16:32:54Z

/verified

backend/src/apiserver/common/config.go

backend/src/v2/cmd/driver/main.go

dsp-developers · 2024-09-06T20:31:58Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 3 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...ec48e88372b28145bd5f5a3afdfb29d3008835a4

UPSTREAM commit ec48e88 has invalid summary Made --mlPipelineServiceTLSEnabled mandatory.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 0ce8846 has invalid summary Created new flag METADATA_TLS_ENABLED.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-09-06T20:35:43Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 4 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...b5f832e46b6307a1e2ad2dd22b6b01e74363c48a

UPSTREAM commit b5f832e has invalid summary Fixed tests.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit ec48e88 has invalid summary Made --mlPipelineServiceTLSEnabled mandatory.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 0ce8846 has invalid summary Created new flag METADATA_TLS_ENABLED.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-09-06T20:40:44Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-72
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-72
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-72
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-72

dsp-developers · 2024-09-06T20:44:42Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-72
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-72
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-72
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-72

dsp-developers · 2024-09-06T21:26:37Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 5 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...09a698ff155926642a4a1766f2f5d43aef3c0c26

UPSTREAM commit 09a698f has invalid summary Revert "Made --mlPipelineServiceTLSEnabled mandatory".

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit b5f832e has invalid summary Fixed tests.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit ec48e88 has invalid summary Made --mlPipelineServiceTLSEnabled mandatory.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 0ce8846 has invalid summary Created new flag METADATA_TLS_ENABLED.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-09-06T21:30:06Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 6 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...b726e8be40102b163be514dc53079cdea982651b

UPSTREAM commit b726e8b has invalid summary Made MetadataTLSEnabled optional.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 09a698f has invalid summary Revert "Made --mlPipelineServiceTLSEnabled mandatory".

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit b5f832e has invalid summary Fixed tests.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit ec48e88 has invalid summary Made --mlPipelineServiceTLSEnabled mandatory.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 0ce8846 has invalid summary Created new flag METADATA_TLS_ENABLED.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-09-06T21:35:18Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-72
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-72
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-72
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-72

dsp-developers · 2024-09-06T21:38:55Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-72
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-72
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-72
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-72

dsp-developers · 2024-09-06T21:44:25Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 7 commits between a8fbbd2020d280f4cab31245a9639a350207b3f9...176072939f9514b3a7c9e0cede84d9a76be5b134

UPSTREAM commit 1760729 has invalid summary Fixed tests.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit b726e8b has invalid summary Made MetadataTLSEnabled optional.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 09a698f has invalid summary Revert "Made --mlPipelineServiceTLSEnabled mandatory".

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit b5f832e has invalid summary Fixed tests.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit ec48e88 has invalid summary Made --mlPipelineServiceTLSEnabled mandatory.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 0ce8846 has invalid summary Created new flag METADATA_TLS_ENABLED.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-09-06T21:53:06Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-72
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-72
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-72
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-72
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-72
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-72

gregsheremeta · 2024-09-20T22:08:12Z

/lgtm

I think the commit checker is mad at you though :)

hbelmiro · 2024-09-24T12:10:04Z

/lgtm

I think the commit checker is mad at you though :)

Commits squashed.
This is ready for a second review.

backend/src/v2/metadata/client.go

backend/src/v2/compiler/argocompiler/importer.go

Signed-off-by: hbelmiro <[email protected]> Signed-off-by: Helber Belmiro <[email protected]>

HumairAK · 2024-09-24T20:48:36Z

great work!
/lgtm
/approve

openshift-ci · 2024-09-24T20:48:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress label Aug 13, 2024

hbelmiro force-pushed the RHOAIENG-4971 branch 2 times, most recently from 4dd36fc to a6f385c Compare August 30, 2024 19:03

hbelmiro changed the title ~~WIP - RHOAIENG-4971~~ UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server Aug 30, 2024

opendatahub-io deleted a comment from dsp-developers Aug 30, 2024

hbelmiro mentioned this pull request Aug 30, 2024

Added support for TLS to MLMD GRPC Server opendatahub-io/data-science-pipelines-operator#683

Merged

3 tasks

hbelmiro marked this pull request as ready for review August 30, 2024 19:23

openshift-ci bot removed the do-not-merge/work-in-progress label Aug 30, 2024

openshift-ci bot requested review from gmfrasca and gregsheremeta August 30, 2024 19:23

HumairAK reviewed Sep 6, 2024

View reviewed changes

backend/src/apiserver/common/config.go Outdated Show resolved Hide resolved

HumairAK reviewed Sep 6, 2024

View reviewed changes

backend/src/v2/cmd/driver/main.go Outdated Show resolved Hide resolved

openshift-ci bot assigned gregsheremeta Sep 20, 2024

openshift-ci bot added the lgtm label Sep 20, 2024

hbelmiro force-pushed the RHOAIENG-4971 branch from 1760729 to 37aa5b5 Compare September 23, 2024 20:32

openshift-ci bot removed the lgtm label Sep 23, 2024

hbelmiro force-pushed the RHOAIENG-4971 branch from 37aa5b5 to ff444eb Compare September 24, 2024 12:07

HumairAK reviewed Sep 24, 2024

View reviewed changes

backend/src/v2/metadata/client.go Show resolved Hide resolved

HumairAK reviewed Sep 24, 2024

View reviewed changes

backend/src/v2/compiler/argocompiler/importer.go Show resolved Hide resolved

UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server

5586f80

Signed-off-by: hbelmiro <[email protected]> Signed-off-by: Helber Belmiro <[email protected]>

hbelmiro force-pushed the RHOAIENG-4971 branch from ff444eb to 5586f80 Compare September 24, 2024 19:57

openshift-ci bot assigned HumairAK Sep 24, 2024

openshift-ci bot added the lgtm label Sep 24, 2024

openshift-ci bot added the approved label Sep 24, 2024

HumairAK merged commit ea7df04 into opendatahub-io:master Sep 24, 2024
3 checks passed

hbelmiro deleted the RHOAIENG-4971 branch September 24, 2024 21:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server #72

UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server #72

hbelmiro commented Aug 13, 2024 •

edited

Loading

dsp-developers commented Aug 13, 2024

dsp-developers commented Aug 13, 2024

dsp-developers commented Aug 30, 2024

dsp-developers commented Aug 30, 2024

VaniHaripriya commented Sep 4, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

gregsheremeta commented Sep 20, 2024

hbelmiro commented Sep 24, 2024

HumairAK commented Sep 24, 2024

openshift-ci bot commented Sep 24, 2024

UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server #72

UPSTREAM: <carry>: Added support for TLS to MLMD GRPC Server #72

Conversation

hbelmiro commented Aug 13, 2024 • edited Loading

dsp-developers commented Aug 13, 2024

dsp-developers commented Aug 13, 2024

dsp-developers commented Aug 30, 2024

Commit Checker results:

dsp-developers commented Aug 30, 2024

VaniHaripriya commented Sep 4, 2024

dsp-developers commented Sep 6, 2024

Commit Checker results:

dsp-developers commented Sep 6, 2024

Commit Checker results:

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

Commit Checker results:

dsp-developers commented Sep 6, 2024

Commit Checker results:

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

dsp-developers commented Sep 6, 2024

Commit Checker results:

dsp-developers commented Sep 6, 2024

gregsheremeta commented Sep 20, 2024

hbelmiro commented Sep 24, 2024

HumairAK commented Sep 24, 2024

openshift-ci bot commented Sep 24, 2024

hbelmiro commented Aug 13, 2024 •

edited

Loading