UPSTREAM: <carry>: Upgrade go version to 1.21 and go.mod package versions #56

DharmitD · 2024-06-11T21:52:25Z

Description of your changes:
Upgrade go version to 1.21
Resolve go.opentelemetry.io/contrib package related CVEs by upgrading package version to latest
Update License CSVs
Remove follow tags to be in sync with cpaas midstream.

Implemented fixes on my fork, tested them out by importing the fork in my personal snyk account and making sure the CVEs were eliminated.

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

dsp-developers · 2024-06-11T21:53:28Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...fe059b09fba2abc679beaf8bb375bc6563381e19

dsp-developers · 2024-06-12T16:04:50Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...750bb84227c3f507ec42f40fea6206ea88f0b7d9

dsp-developers · 2024-06-12T18:03:11Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...f860573b99119c7af9001520c2e165a69bd521b4

dsp-developers · 2024-06-12T18:12:11Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-56
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-56
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-56
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-56
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-56
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-56

dsp-developers · 2024-06-12T18:37:08Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...54482e6db9aaddca67168d87bdf11d2f73ea7c44

dsp-developers · 2024-06-12T18:46:03Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-56
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-56
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-56
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-56
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-56
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-56

amadhusu · 2024-06-13T11:46:11Z

backend/Dockerfile.driver

@@ -16,8 +16,8 @@
 ARG SOURCE_CODE=.

 # Use ubi8/nodejs-14 as base image
-#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1.20)
-FROM registry.access.redhat.com/ubi8/go-toolset:1.20 as builder
+#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1)


Doesn't matter much but there is a typo here in the #@follow_tag, it should be registry.access.redhat.com/ubi8/go-toolset:21 but apart from that tested overall and it looks good.

Done, updated it to be 1.21. Thanks!

dsp-developers · 2024-06-13T14:59:24Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...2c264cc72d62f6941bccfbf2f01f23b6e35b64a5

dsp-developers · 2024-06-13T15:08:20Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-56
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-56
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-56
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-56
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-56
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-56

HumairAK · 2024-06-13T16:20:41Z

backend/Dockerfile.viewercontroller

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.

-FROM golang:1.20.4-alpine3.17 as builder
+FROM golang:1.21.4-alpine3.17 as builder


some dockerfiles look like they weren't updated like launcher, can you go over those again?

done, updated all dockerfiles.

dsp-developers · 2024-06-13T16:33:42Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 2 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...480e9a0c6e210ed64c80c7beb2a7e5366945c4e2

UPSTREAM commit 480e9a0 has invalid summary Update go version references to 1.21.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-06-13T17:51:28Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 2 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...1863072239509ed51ac4a2fbc8a2e525f504a8be

dsp-developers · 2024-06-13T18:00:50Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-56
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-56
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-56
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-56
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-56
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-56

gmfrasca · 2024-06-13T20:29:57Z

backend/Dockerfile.launcher

@@ -18,8 +18,8 @@ ARG CI_CONTAINER_VERSION="unknown"


 # Use ubi8/nodejs-14 as base image
-#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1.20)
-FROM registry.access.redhat.com/ubi8/go-toolset:1.20 as builder
+#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1.21)


@follow_tags have been removed from midstream, so we should do it here too

Done, removed tags.

gmfrasca · 2024-06-13T20:30:04Z

backend/Dockerfile.driver

@@ -16,8 +16,8 @@
 ARG SOURCE_CODE=.

 # Use ubi8/nodejs-14 as base image
-#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1.20)
-FROM registry.access.redhat.com/ubi8/go-toolset:1.20 as builder
+#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1.21)


@follow_tags have been removed from midstream, so we should do it here too

Done, removed tags.

gmfrasca · 2024-06-13T20:30:14Z

backend/Dockerfile

@@ -15,8 +15,8 @@
 # Build arguments
 ARG SOURCE_CODE=.

-#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1.20)
-FROM registry.access.redhat.com/ubi8/go-toolset:1.20 as builder
+#@follow_tag(registry.access.redhat.com/ubi8/go-toolset:1.21)


@follow_tags have been removed from midstream, so we should do it here too

Done, removed tags.

gmfrasca

small comment-removal comments, but otherwise /lgtm

gmfrasca · 2024-06-13T20:42:16Z

that said, since you updated go.mod, you'll need to update the license CSVs. you can do that by simply running make all in backend/

dsp-developers · 2024-06-13T21:24:40Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 3 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...f90fb046f7a9b8120334a11ab063220cc2dede83

dsp-developers · 2024-06-13T21:30:56Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 4 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...40420106906722c7b20708c5dfd7dad8fca9d53e

DharmitD · 2024-06-13T21:31:16Z

that said, since you updated go.mod, you'll need to update the license CSVs. you can do that by simply running make all in backend/

Done, updated the license CSVs.

dsp-developers · 2024-06-13T21:34:48Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-56
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-56
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-56
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-56
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-56
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-56

gmfrasca

/lgtm

dsp-developers · 2024-06-13T21:41:19Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-56
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-56
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-56
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-56
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-56
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-56

…ions

dsp-developers · 2024-06-14T15:13:34Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between ea6815018f49bdb884ff5b955b946f64ffc8f648...f46e5106dd958d92ca85f5c2942306a7b1bb4a69

dsp-developers · 2024-06-14T15:22:33Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-56
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-56
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-56
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-56
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-56
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-56

HumairAK · 2024-06-14T15:38:25Z

/lgtm
/approve

openshift-ci · 2024-06-14T15:38:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsp-developers · 2024-06-14T15:39:23Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...f46e5106dd958d92ca85f5c2942306a7b1bb4a69

openshift-ci bot requested review from amadhusu and gmfrasca June 11, 2024 21:52

DharmitD mentioned this pull request Jun 11, 2024

UPSTREAM: <carry>: Upgrade go version to 1.21 and resolve CVEs red-hat-data-services/data-science-pipelines#13

Closed

1 task

DharmitD force-pushed the go-version-cve branch from fe059b0 to 750bb84 Compare June 12, 2024 16:03

DharmitD changed the title ~~UPSTREAM: <carry>: Upgrade go version to 1.21 and resolve CVEs~~ UPSTREAM: <carry>: Upgrade go version to 1.21 and go.opentelemetry.io/contrib package version Jun 12, 2024

DharmitD changed the title ~~UPSTREAM: <carry>: Upgrade go version to 1.21 and go.opentelemetry.io/contrib package version~~ UPSTREAM: <carry>: Upgrade go version to 1.21 and contrib package version Jun 12, 2024

DharmitD changed the title ~~UPSTREAM: <carry>: Upgrade go version to 1.21 and contrib package version~~ UPSTREAM: <carry>: Upgrade go version to 1.21 and go.mod package versions Jun 12, 2024

DharmitD force-pushed the go-version-cve branch from 750bb84 to f860573 Compare June 12, 2024 18:02

amadhusu approved these changes Jun 13, 2024

View reviewed changes

openshift-ci bot assigned amadhusu Jun 13, 2024

openshift-ci bot added the lgtm label Jun 13, 2024

DharmitD force-pushed the go-version-cve branch from 54482e6 to 2c264cc Compare June 13, 2024 14:58

openshift-ci bot removed the lgtm label Jun 13, 2024

HumairAK reviewed Jun 13, 2024

View reviewed changes

DharmitD force-pushed the go-version-cve branch from 2c264cc to 2be0e1d Compare June 13, 2024 16:22

openshift-merge-robot added the needs-rebase label Jun 13, 2024

DharmitD force-pushed the go-version-cve branch from 2be0e1d to 480e9a0 Compare June 13, 2024 16:32

openshift-merge-robot removed the needs-rebase label Jun 13, 2024

DharmitD force-pushed the go-version-cve branch from 480e9a0 to 1863072 Compare June 13, 2024 17:50

gmfrasca reviewed Jun 13, 2024

View reviewed changes

DharmitD mentioned this pull request Jun 13, 2024

UPSTREAM: <carry>: Upgrade DSP go.mod package versions #55

Merged

1 task

gmfrasca reviewed Jun 13, 2024

View reviewed changes

openshift-ci bot assigned gmfrasca Jun 13, 2024

openshift-ci bot added the lgtm label Jun 13, 2024

DharmitD mentioned this pull request Jun 14, 2024

UPSTREAM: <carry>: Upgrade DSP api/go.mod package versions #54

Merged

1 task

DharmitD force-pushed the go-version-cve branch from 4042010 to 4c09909 Compare June 14, 2024 14:57

openshift-ci bot removed the lgtm label Jun 14, 2024

openshift-merge-robot added the needs-rebase label Jun 14, 2024

UPSTREAM: <carry>: Upgrade go version to 1.21 and go.mod package vers…

f46e510

…ions

DharmitD force-pushed the go-version-cve branch from 4c09909 to f46e510 Compare June 14, 2024 15:12

openshift-merge-robot removed the needs-rebase label Jun 14, 2024

openshift-ci bot assigned HumairAK Jun 14, 2024

HumairAK merged commit dadfb38 into opendatahub-io:master Jun 14, 2024
2 of 3 checks passed

openshift-ci bot added the lgtm label Jun 14, 2024

openshift-ci bot added the approved label Jun 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UPSTREAM: <carry>: Upgrade go version to 1.21 and go.mod package versions #56

UPSTREAM: <carry>: Upgrade go version to 1.21 and go.mod package versions #56

DharmitD commented Jun 11, 2024 •

edited

Loading

dsp-developers commented Jun 11, 2024

dsp-developers commented Jun 12, 2024

dsp-developers commented Jun 12, 2024

dsp-developers commented Jun 12, 2024

dsp-developers commented Jun 12, 2024

dsp-developers commented Jun 12, 2024

amadhusu Jun 13, 2024

DharmitD Jun 13, 2024

dsp-developers commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

HumairAK Jun 13, 2024

DharmitD Jun 13, 2024

dsp-developers commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

gmfrasca Jun 13, 2024

DharmitD Jun 13, 2024

gmfrasca Jun 13, 2024

DharmitD Jun 13, 2024

gmfrasca Jun 13, 2024

DharmitD Jun 13, 2024

gmfrasca left a comment

gmfrasca commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

DharmitD commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

gmfrasca left a comment

dsp-developers commented Jun 13, 2024

dsp-developers commented Jun 14, 2024

dsp-developers commented Jun 14, 2024

HumairAK commented Jun 14, 2024

openshift-ci bot commented Jun 14, 2024

dsp-developers commented Jun 14, 2024

UPSTREAM: <carry>: Upgrade go version to 1.21 and go.mod package versions #56

UPSTREAM: <carry>: Upgrade go version to 1.21 and go.mod package versions #56

Conversation

DharmitD commented Jun 11, 2024 • edited Loading

dsp-developers commented Jun 11, 2024

Commit Checker results:

dsp-developers commented Jun 12, 2024

Commit Checker results:

dsp-developers commented Jun 12, 2024

Commit Checker results:

dsp-developers commented Jun 12, 2024

dsp-developers commented Jun 12, 2024

Commit Checker results:

dsp-developers commented Jun 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsp-developers commented Jun 13, 2024

Commit Checker results:

dsp-developers commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsp-developers commented Jun 13, 2024

Commit Checker results:

dsp-developers commented Jun 13, 2024

Commit Checker results:

dsp-developers commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmfrasca left a comment

Choose a reason for hiding this comment

gmfrasca commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

Commit Checker results:

dsp-developers commented Jun 13, 2024

Commit Checker results:

DharmitD commented Jun 13, 2024

dsp-developers commented Jun 13, 2024

gmfrasca left a comment

Choose a reason for hiding this comment

dsp-developers commented Jun 13, 2024

dsp-developers commented Jun 14, 2024

Commit Checker results:

dsp-developers commented Jun 14, 2024

HumairAK commented Jun 14, 2024

openshift-ci bot commented Jun 14, 2024

dsp-developers commented Jun 14, 2024

Commit Checker results:

DharmitD commented Jun 11, 2024 •

edited

Loading