Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: feat: mount EmptyDir volumes for launcher write locations pt 2 #32

Merged

Conversation

gregsheremeta
Copy link

@gregsheremeta gregsheremeta commented Apr 3, 2024

follows up on dfe6edc, which does an EmptyDir mount for /.local and /.cache. /.config is another common write location, so EmptyDir mount that too.

To test, verify that this pipeline now works:
https://github.com/kubeflow/pipelines/blob/master/samples/v2/producer_consumer_param.py

Checklist:

…cations pt 2

follows up on dfe6edc, which does an EmptyDir mount for /.local and /.cache.
/.config is another common write location, so EmptyDir mount that too.
@openshift-ci openshift-ci bot requested review from DharmitD and rimolive April 3, 2024 18:03
@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-32
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-32
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-32
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-32
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-32
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-32

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-32.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-32
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-32"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-32"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-32"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-32"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-32"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-32"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/32/head
git checkout -b pullrequest e428f162058b5bceab6689941d730ffb581f5ec8
oc apply -f dspa.pr-32.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link

HumairAK commented Apr 8, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6d59438 into opendatahub-io:master Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants