Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: UPSTREAM: <carry>: feat(backend): Upgrade argo to v3.4.16 #28

Closed
wants to merge 5 commits into from

Conversation

gmfrasca
Copy link
Member

Description of your changes:
Upstream Carried Patch of kubeflow#10568

Checklist:

- Argo 3.4.16 upgrade introduces a breaking change with inconsistent node.ID vs
  node.Name
- introduce a function in workflow.go to conditionally handle this

Signed-off-by: Giulio Frasca <[email protected]>
…Executor ConfigMap Key

- PNS Executor was removed in Argo v3.4, so manifests no longer valid
- WorkflowController will fail to start if `containerRuntimeExecutor`
  provided as input parameter, so remove from WC ConfigMap and CM
  patches

Signed-off-by: Giulio Frasca <[email protected]>
Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gregsheremeta
Copy link

are we making changes to what is in the upstream pipelines repo? If not, then it should not be labeled as a carry, and we replace the word "carry" with the pipelines PR number.

Ref: https://github.com/openshift/kubernetes/blob/master/REBASE.openshift.md#picking-commits-from-the-previous-rebase-branch-to-the-new-branch

so:

WIP: UPSTREAM: 10568: feat(backend): Upgrade argo to v3.4.16

per the doc

A commit with this message should only be picked into the subsequent rebase branch if the commits of the referenced PR are not included in the upstream branch.

cc @HumairAK who was wondering if we're using the labels correctly

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants