Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated envoy and grpc image URLs for bot #25

Merged

Conversation

amadhusu
Copy link

Description of your changes:
Updated envoy and grpc image URLs for bot to comment on PRs.

Checklist:

@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-25
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-25
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-25
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-25
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-25
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-25
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-25
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-25

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-25.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-25
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-25"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-25"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-25"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-25"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-25"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-25"
    envoy:
      image: "quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-25"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-25"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/25/head
git checkout -b pullrequest ff2f239453fc314e76e269b50a5cab6d623ba9c9
oc apply -f dspa.pr-25.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@rimolive
Copy link

/lgtm

@rimolive
Copy link

/approve

Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1e89b60 into opendatahub-io:master Mar 12, 2024
2 checks passed
@gregsheremeta
Copy link

@amadhusu @rimolive are you sure the GRPC one is correct? Pulling and starting gives me an error:

ds-pipeline-metadata-grpc-uxdkfpdemo-85bd8c56f7-cltsk
...
Successfully pulled image "quay.io/opendatahub/model-registry:latest" in 179.361789ms (179.37745ms including waiting)
...
Error: container create failed: time="2024-03-12T20:47:27Z" level=error msg="runc create failed: unable to start container process: exec: \"/bin/metadata_store_server\": stat /bin/metadata_store_server: no such file or directory"

@rimolive
Copy link

@gregsheremeta
Copy link

Fix: #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants