Use UBI images and make samples optional

[HumairAK]

Resolves:

• https://issues.redhat.com/browse/RHOAIENG-4383

Related:

• https://issues.redhat.com/browse/RHOAIENG-4278

Use UBI images to deploy dspa similar to how we do it in downstream and remove passing default samples (we do not want to provide samples by default).

To accomplish the latter, we have to provide a fix to not error out when no samples are provided.

To test:

• Set DSPA with enableSamplePipeline to false, and ensure no pipeline shows up.
• Deploy the dspa with these new images built, run a pipeline

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsp-developers]

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-23
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-23
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-23
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-23
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-23
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-23
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-23
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-23

[dsp-developers]

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-23.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-23
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-23"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-23"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-23"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-23"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-23"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-23"
    envoy:
      image: "quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-23"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-23"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/23/head
git checkout -b pullrequest c5bda03f49533df37533164972d93724db0f4554
oc apply -f dspa.pr-23.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

[gregsheremeta]

/lgtm

[dsp-developers]

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-23
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-23
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-23
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-23
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-23
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-23
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-23
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-23

[amadhusu]

/lgtm
/approve