UPSTREAM: <carry>: Update ArtifactView enum to allow pipelines artifacts api to have optional content disposition #118

VaniHaripriya · 2024-11-15T01:33:52Z

Description of your changes:
This PR resolves # RHOAIENG-12014

This PR improves the Pipelines Artifacts API by adding flexible URL options for artifact retrieval.
It introduces a new RENDER field to the enum, which, when selected, provides a signed URL without the content disposition header.
Updated DOWNLOAD view to download the artifact instead of showing preview and then download.
This allows for the immediate download of artifacts in some cases, while also enabling preview or rendering in other scenarios.

Testing Instructions:

Deploy DSPA using this API Server image - quay.io/opendatahub/ds-pipelines-api-server:pr-118
Create a pipeline run and use the below api to verify the changes in artifact view options:

 For DOWNLOAD view:

   url - /apis/v2beta1/artifacts/1?view=DOWNLOAD
   Method : GET

Sample Response:
{
"artifact_id": "1",
"storage_provider": "s3",
"storage_path": "iris-training-pipeline/70e74c8c-fbe7-41a8-a20e-0dfb84db5516/create-dataset/iris_dataset",
"uri": "s3://mlpipeline/iris-training-pipeline/70e74c8c-fbe7-41a8-a20e-0dfb84db5516/create-dataset/iris_dataset",
"download_url": "https://minio-sample-dspa.apps.vmudadla-1.dev.datahub.redhat.com/mlpipeline/iris-training-pipeline/70e74c8c-fbe7-41a8-a20e-0dfb84db5516/create-dataset/iris_dataset?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=MgVISopjwQeEKLWa%2F20241125%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241125T171009Z&X-Amz-Expires=60&X-Amz-SignedHeaders=host&response-content-disposition=attachment%3B%20filename%3D%22iris-training-pipeline%2F70e74c8c-fbe7-41a8-a20e-0dfb84db5516%2Fcreate-dataset%2Firis_dataset%22&X-Amz-Signature=88261cc9cb8fd40a5f29b67ac7e4bb2068ae636cbaa2840282d7e32fde86611f",
"namespace": "dspa",
"artifact_type": "system.Dataset",
"artifact_size": "5098",
"created_at": "2024-11-22T22:26:42.147Z",
"last_updated_at": "2024-11-22T22:26:42.147Z"
}

Open the download_url in a browser, and the artifact should automatically start downloading.

 For RENDER view:

   url - /apis/v2beta1/artifacts/1?view=RENDER
   Method : GET

Sample Response:
{
"artifact_id": "1",
"storage_provider": "s3",
"storage_path": "iris-training-pipeline/70e74c8c-fbe7-41a8-a20e-0dfb84db5516/create-dataset/iris_dataset",
"uri": "s3://mlpipeline/iris-training-pipeline/70e74c8c-fbe7-41a8-a20e-0dfb84db5516/create-dataset/iris_dataset",
"namespace": "dspa",
"artifact_type": "system.Dataset",
"artifact_size": "5098",
"created_at": "2024-11-22T22:26:42.147Z",
"last_updated_at": "2024-11-22T22:26:42.147Z",
"render_url": "https://minio-sample-dspa.apps.vmudadla-1.dev.datahub.redhat.com/mlpipeline/iris-training-pipeline/70e74c8c-fbe7-41a8-a20e-0dfb84db5516/create-dataset/iris_dataset?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=MgVISopjwQeEKLWa%2F20241125%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241125T195517Z&X-Amz-Expires=60&X-Amz-SignedHeaders=host&response-content-disposition=inline&X-Amz-Signature=e543aeab6b98b8e82f79b45d5a24ab154949430da8c21db6c8024e5c1eef7d18"

}
```
Open the render_url in a browser to view a preview of the artifact.

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

openshift-ci · 2024-11-15T01:33:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gregsheremeta for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsp-developers · 2024-11-15T01:34:54Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 3 commits between e27b68731776c35efe5e363295c3cc4a782cec4f...6e694366abc04d1d8dc8d8f9bdda52a4ee03d626

UPSTREAM commit 6e69436 has invalid summary Update signedurl.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 156c4dd has invalid summary Updated swagger.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 17bcd01 has invalid summary Update ArifactView enum to allow pipelines artifacts api to have optional content disposition.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-15T01:36:13Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from e27b68731776c35efe5e363295c3cc4a782cec4f..f80f8616d30bb5c8a8b4c57ad40b271e6cc68474: error executing git log: fatal: Invalid revision range e27b68731776c35efe5e363295c3cc4a782cec4f..f80f8616d30bb5c8a8b4c57ad40b271e6cc68474
: exit status 128

dsp-developers · 2024-11-15T01:37:06Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between e27b68731776c35efe5e363295c3cc4a782cec4f...74d1b1fa1c21319f01228d4d1d274bf02c512bf6

UPSTREAM commit 74d1b1f has invalid summary Update ArifactView enum to allow pipelines artifacts api to have optional content disposition.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-15T01:44:27Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from e27b68731776c35efe5e363295c3cc4a782cec4f..c4e69f8162abb6610ac403ddae389c39fb16c91c: error executing git log: fatal: Invalid revision range e27b68731776c35efe5e363295c3cc4a782cec4f..c4e69f8162abb6610ac403ddae389c39fb16c91c
: exit status 128

dsp-developers · 2024-11-15T01:44:55Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between e27b68731776c35efe5e363295c3cc4a782cec4f...35108eeaac314fbb9fe9d638a0b73c32bd783168

UPSTREAM commit 35108ee has invalid summary Update ArifactView enum to allow pipelines artifacts api to have optional content disposition.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-15T01:47:51Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between e27b68731776c35efe5e363295c3cc4a782cec4f...a2234bab86edf454157be9792259893332f652c6

dsp-developers · 2024-11-19T19:37:43Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from 7c3b0204f09934458ccd7ce65deba74fb0146286..e2464055788506a67239dccf68007fd136d3db94: error executing git log: fatal: Invalid revision range 7c3b0204f09934458ccd7ce65deba74fb0146286..e2464055788506a67239dccf68007fd136d3db94
: exit status 128

dsp-developers · 2024-11-19T19:38:20Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...560543daaba6fb73564d7279b900297e2d0a1021

dsp-developers · 2024-11-19T19:46:48Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-19T19:47:45Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-19T19:50:41Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...b2c1022b258a74014b0ddd7090b523b7a857dd46

dsp-developers · 2024-11-19T20:00:09Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-19T20:04:32Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...97287e36caa59dff93ce33e9d3db95e10bb840eb

dsp-developers · 2024-11-19T20:14:09Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...f3877f42021bca317f6d808be8e5f66c398b7918

dsp-developers · 2024-11-19T20:14:20Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-19T20:22:42Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-19T20:29:57Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...37e68e1aebe6d498d7ce7243a69606d9f68c6457

dsp-developers · 2024-11-19T20:39:31Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-19T20:52:48Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...1385dcea9c4b63bd3c10a7623f904a3098e17c54

dsp-developers · 2024-11-19T21:02:03Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-22T18:33:57Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...0570a6ab6bb21dc7f016b72c7ba514b5c25eebfc

dsp-developers · 2024-11-22T18:44:52Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-22T18:58:47Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...03a51c2b958f4d06b79f8b8c19d28085e0a4a086

dsp-developers · 2024-11-22T19:11:06Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

dsp-developers · 2024-11-22T20:11:27Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...2e5fc933a13e1693ddc895ec3b85ad82da00c02a

dsp-developers · 2024-11-22T20:21:44Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

…s api to have optional content disposition Signed-off-by: VaniHaripriya <[email protected]>

dsp-developers · 2024-11-25T17:14:02Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...41d686438f32792521c59da19f49477f587ead84

dsp-developers · 2024-11-25T17:23:01Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-118
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-118
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-118
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-118
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-118
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-118

hbelmiro · 2024-12-03T19:00:46Z

@VaniHaripriya both URLs took me to the very same screen. Is that the expected result?

hbelmiro

/lgtm

as long as #118 (comment) is the expected result.

hbelmiro · 2024-12-03T19:15:01Z

/hold for #118 (comment)

hbelmiro · 2024-12-03T21:50:02Z

/unhold
I was probably taking too much time to open the URLs.
I re-tested on a different browser and it works as expected.

openshift-ci bot added the do-not-merge/work-in-progress label Nov 15, 2024

VaniHaripriya force-pushed the RHOAIENG-12014 branch 2 times, most recently from f80f861 to 74d1b1f Compare November 15, 2024 01:35

VaniHaripriya force-pushed the RHOAIENG-12014 branch from c4e69f8 to 35108ee Compare November 15, 2024 01:44

VaniHaripriya force-pushed the RHOAIENG-12014 branch from 35108ee to a2234ba Compare November 15, 2024 01:46

VaniHaripriya force-pushed the RHOAIENG-12014 branch from e246405 to 560543d Compare November 19, 2024 19:37

VaniHaripriya removed the do-not-merge/work-in-progress label Nov 19, 2024

VaniHaripriya marked this pull request as ready for review November 19, 2024 20:50

openshift-ci bot requested review from DharmitD and rimolive November 19, 2024 20:50

VaniHaripriya force-pushed the RHOAIENG-12014 branch from 37e68e1 to 1385dce Compare November 19, 2024 20:51

rimolive changed the title ~~UPSTREAM: <carry>: Update ArifactView enum to allow pipelines artifacts api to have optional content disposition~~ UPSTREAM: <carry>: Update ArtifactView enum to allow pipelines artifacts api to have optional content disposition Nov 20, 2024

VaniHaripriya force-pushed the RHOAIENG-12014 branch from b0d161c to 03a51c2 Compare November 22, 2024 18:54

UPSTREAM: <carry>:Update ArifactView enum to allow pipelines artifact…

41d6864

…s api to have optional content disposition Signed-off-by: VaniHaripriya <[email protected]>

VaniHaripriya force-pushed the RHOAIENG-12014 branch from 2e5fc93 to 41d6864 Compare November 25, 2024 17:13

hbelmiro reviewed Dec 3, 2024

View reviewed changes

openshift-ci bot assigned hbelmiro Dec 3, 2024

openshift-ci bot added the lgtm label Dec 3, 2024

openshift-ci bot added the do-not-merge/hold label Dec 3, 2024

openshift-ci bot removed the do-not-merge/hold label Dec 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UPSTREAM: <carry>: Update ArtifactView enum to allow pipelines artifacts api to have optional content disposition #118

UPSTREAM: <carry>: Update ArtifactView enum to allow pipelines artifacts api to have optional content disposition #118

VaniHaripriya commented Nov 15, 2024 •

edited

Loading

openshift-ci bot commented Nov 15, 2024

dsp-developers commented Nov 15, 2024

dsp-developers commented Nov 15, 2024

dsp-developers commented Nov 15, 2024

dsp-developers commented Nov 15, 2024

dsp-developers commented Nov 15, 2024

dsp-developers commented Nov 15, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 25, 2024

dsp-developers commented Nov 25, 2024

hbelmiro commented Dec 3, 2024

hbelmiro left a comment

hbelmiro commented Dec 3, 2024

hbelmiro commented Dec 3, 2024

UPSTREAM: <carry>: Update ArtifactView enum to allow pipelines artifacts api to have optional content disposition #118

Are you sure you want to change the base?

UPSTREAM: <carry>: Update ArtifactView enum to allow pipelines artifacts api to have optional content disposition #118

Conversation

VaniHaripriya commented Nov 15, 2024 • edited Loading

openshift-ci bot commented Nov 15, 2024

dsp-developers commented Nov 15, 2024

Commit Checker results:

dsp-developers commented Nov 15, 2024

Commit Checker results:

dsp-developers commented Nov 15, 2024

Commit Checker results:

dsp-developers commented Nov 15, 2024

Commit Checker results:

dsp-developers commented Nov 15, 2024

Commit Checker results:

dsp-developers commented Nov 15, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 19, 2024

Commit Checker results:

dsp-developers commented Nov 19, 2024

dsp-developers commented Nov 22, 2024

Commit Checker results:

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 22, 2024

Commit Checker results:

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 22, 2024

Commit Checker results:

dsp-developers commented Nov 22, 2024

dsp-developers commented Nov 25, 2024

Commit Checker results:

dsp-developers commented Nov 25, 2024

hbelmiro commented Dec 3, 2024

hbelmiro left a comment

Choose a reason for hiding this comment

hbelmiro commented Dec 3, 2024

hbelmiro commented Dec 3, 2024

VaniHaripriya commented Nov 15, 2024 •

edited

Loading