Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy fix header handling for X-Forwarded-For etc. #1090

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Nov 18, 2024

This is #1085 cherry-picked to the main branch. The commit that fixed type annotations is omitted since there is no type signature on that function in 1.8.


📚 Documentation preview 📚: https://datacube-ows--1090.org.readthedocs.build/en/1090/

@pjonsson pjonsson force-pushed the proxy-fix branch 3 times, most recently from fd1b74c to 4a4e072 Compare November 18, 2024 11:34
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (82c9c77) to head (100d230).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
datacube_ows/startup_utils.py 42.85% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   93.64%   93.58%   -0.06%     
==========================================
  Files          43       43              
  Lines        6510     6518       +8     
==========================================
+ Hits         6096     6100       +4     
- Misses        414      418       +4     
Files with missing lines Coverage Δ
datacube_ows/ogc.py 85.29% <100.00%> (+0.10%) ⬆️
datacube_ows/startup_utils.py 90.32% <42.85%> (-2.25%) ⬇️
---- 🚨 Try these New Features:

@pjonsson
Copy link
Contributor Author

@alexgleith seems my nginx rewrites URLs in the response for GetCapabilities already, so I can't test this. The git conflicts were just about functions being in different modules though.

Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SpacemanPaul SpacemanPaul merged commit 92bdb24 into opendatacube:master Nov 20, 2024
12 checks passed
@pjonsson pjonsson deleted the proxy-fix branch November 20, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants