-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker image for debugging. #1080
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 43 43
Lines 6510 6510
=======================================
Hits 6096 6096
Misses 414 414
|
@pjonsson Any of this unnecessary? (Anything I've missed?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My ows-rebuild patches in the apt-get upgrade -y
, so it's nice to get it into the Dockerfile instead.
I have not used pydevd, but on Ubuntu, you automatically get a new PyCharm as soon as it is released. If it works the same on Windows/Mac and pydevd versions are tied to PyCharm versions, it might be easiest to just drop the version constraint on pydevd and always get the latest. But do that in a separate PR, this PR makes it work and that is worth a lot.
Unrelated to this PR, it would be nice with a datacube-ows release with the cache-fixes and your fix that makes it stop spamming the logs with warnings.
I'm out of commission now and it will most likely last for the rest of the week, so don't hold this waiting for me, but for what it is worth, I think this change looks good.
* Hackathon WIP * Fix Docker image for debugging. * Additional docker fixes from #1080 * Tweak antimeridian hack and timezone handling. * Misc cleanup. * Fix tests - auto-publish 3832 if 3857 is published. * Fix tests - pass boxed point instead of raw point. * What layers are getting hidden? * Layer reprs. * Typo from a couple of commits ago. * REALLY fix typo (sigh) * Workaround core bug and cleanup * print to echo fix * Remove separate test db build script.
Recent docker image changes broke debugging. This fixes it.
Changes:
apt-get upgrade -y
: not strictly necessary, but seems like a good idea./code
directory to/src
. This is the important one. pydevd imports stuff from the standard librarycode
which the/code
directory hides. Required some tweaks to GHAs.pipdeptree
as a dev dependency. I can't remember why we needed it and it has pip version dependencies that cause issues because we can't upgrade the Debian-controlled pip.This has been holding up OWS progress for ages and nearly driving me nuts. Relieved to finally have it working again.
📚 Documentation preview 📚: https://datacube-ows--1080.org.readthedocs.build/en/1080/