Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]curveadm: add install tool command #332

Closed
wants to merge 6 commits into from
Closed

[feat]curveadm: add install tool command #332

wants to merge 6 commits into from

Conversation

0fatal
Copy link

@0fatal 0fatal commented Nov 6, 2023

@caoxianfei1
Copy link
Contributor

@0fatal Please push it to develop not tombstone

@0fatal 0fatal force-pushed the feat/install-tool branch 3 times, most recently from 24dbca0 to 565d236 Compare November 24, 2023 11:11
@caoxianfei1
Copy link
Contributor

@0fatal Pls commit it to develop branch again.

@caoxianfei1 caoxianfei1 self-requested a review December 5, 2023 01:57
caoxianfei1
caoxianfei1 reviewed Dec 20, 2023
View reviewed changes
cli/command/install/tool.go
dcs []*topology.DeployConfig,
options installOptions,
) (*playbook.Playbook, error) {
configs := curveadm.FilterDeployConfig(dcs, topology.FilterOption{Id: "*", Role: topology.ROLE_MDS, Host: options.host})[:1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any one service container is ok on the host. ROLE_MDS is not necessary.

caoxianfei1
caoxianfei1 reviewed Dec 20, 2023
View reviewed changes
cli/command/install/tool.go
flags := cmd.Flags()
flags.StringVar(&options.host, "host", "localhost", "Specify target host")
flags.StringVar(&options.path, "path", "/usr/local/bin/curve", "Specify target install path of tool v2")
flags.StringVar(&options.confPath, "confPath", "~/.curve/curve.yaml", "Specify target config path of tool v2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaule value of confPath is /etc/curve/curve.yaml

@caoxianfei1
Copy link
Contributor

@0fatal I'm going to close it because this is the old PR and the new one has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caoxianfei1 caoxianfei1 caoxianfei1 left review comments

Assignees
No one assigned
Labels
developer activities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0fatal @caoxianfei1