[fix]getClusterPool: performing a type conversion on a nil. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Songjf-ttk
force-pushed
the
fix_createpool
branch
from
e7fa8f5
to
93f1003
Compare
fix curveadm is performing a type conversion on a nil. Solution: Add poolset and diskType to the option choices. Signed-off-by: sjf <[email protected]>
Songjf-ttk
force-pushed
the
fix_createpool
branch
from
93f1003
to
ae49c7a
Compare
Songjf-ttk
changed the title
|
@Wine93 @caoxianfei1 Can you help review it |
|
Hi, @Songjf-ttk , thank you for your contribute, we will review it, please don't close it :) |
Thank you, I will fix the CI errors and continue to follow up. |
|
@Songjf-ttk CI failed, please solve this problem. May be some wrong blank or tab. |
Signed-off-by: caoxianfei1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #308
fix curveadm is performing a type conversion on a nil.
Solution: Add poolset and diskType to the option choices. So, there won't be a nil.