support incremental formatting #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuminjian
force-pushed
the
feat/incr-format
branch
from
5325d2a
to
12c6cd2
Compare
|
got! |
|
@liuminjian squash one commit. |
liuminjian
force-pushed
the
feat/incr-format
branch
from
59ee06e
to
168ba62
Compare
done |
caoxianfei1
reviewed
Sep 11, 2023
| -fileSystemPath=$chunkfile_pool_dir | ||
| fi | ||
|
|
||
|
|
There was a problem hiding this comment.
The parameters of curve_format is incremental precent default and seems to be unnecessary to modify the script.
liuminjian
force-pushed
the
feat/incr-format
branch
2 times, most recently
from
8e18359
to
d7c2108
Compare
Wine93
reviewed
Oct 8, 2023
|
|
||
| if [ $minus -gt 0 ] | ||
| then | ||
| $binary \ |
There was a problem hiding this comment.
Maybe it not works, do you have test it?
liuminjian
force-pushed
the
feat/incr-format
branch
2 times, most recently
from
8984710
to
c592f95
Compare
caoxianfei1
reviewed
Oct 11, 2023
| @@ -131,6 +134,7 @@ func genFormatPlaybook(curveadm *cli.CurveAdm, | |||
| stopFormat := options.stopFormat | |||
| debug := options.debug | |||
| clean := options.clean | |||
| increment := options.increment | |||
|
|
|||
| steps := FORMAT_PLAYBOOK_STEPS | |||
| if showStatus { | |||
There was a problem hiding this comment.
may be we can use playbook playbook.STOP_SERVICE.
for example:
FORMAT_INCREMENT_PLAYBOOK_STEPS := int[]{
playbook.STOP_SERVICE,
playbook.FORMAT_CHUNKFILE_POOL,
}
if increment {
steps = FORMAT_INCREMENT_PLAYBOOK_STEPS
}
stopChunkServercs = curveadm.FilterDeployConfig(dcs, topology.FilterOption{
Role: "chunkserver",
})
if len(stopChunkServercs) == 0 {
// no chunkserver
}
if step == playbook.STOP_SERVICE {
pb.AddStep(&playbook.PlaybookStep{
...
Configs: stopChunkServercs
} else ...
}
liuminjian
force-pushed
the
feat/incr-format
branch
2 times, most recently
from
51eac15
to
ddfb79a
Compare
Signed-off-by: liuminjian <[email protected]> support incremental formatting Signed-off-by: liuminjian <[email protected]> support incremental formatting Signed-off-by: liuminjian <[email protected]>
|
LGTM！ |
caoxianfei1
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves #189 .
新增参数--increment
