Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: better build tools-v2 and mount /etc/hosts #2989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: better build tools-v2 and mount /etc/hosts #2989

wants to merge 1 commit into from

Conversation

zztaki
Copy link
Contributor

@zztaki zztaki commented Jan 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: #2602 and #2978

Problem Summary:

  1. tools-v2 is in the main process of compiling and cannot be skipped.
  2. go1.12.8 dependency can't be downloaded due to resolving incorrect DNS address. Maybe you can see this.

What is changed and how it works?

What's Changed:

  1. When only(akw. target) is specified when building, we will no longer compile tools-v2. (Warning: this will also happen if you manually specify all modules for only)
  2. mount /etc/hosts to docker.

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@zztaki
Copy link
Contributor Author

zztaki commented Jan 14, 2024

cicheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zztaki