[RFC] Linux Network Devices #4538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aojea
force-pushed
the
netdevices
branch
2 times, most recently
from
bdb31c1 to
0b771ca
Compare
aojea
commented
Dec 2, 2024
tests/integration/netdev.bats
Outdated
| [[ "$output" == *"2001:db8::2/64"* ]] | ||
|
|
||
| ip netns del "$ns_name" | ||
| ip link del dev dummy1 |
There was a problem hiding this comment.
this guarantees the interface is brought back to the root namespcae, otherwise this command will fail
aojea
force-pushed
the
netdevices
branch
2 times, most recently
from
07d3b0b to
3833056
Compare
kad
reviewed
Dec 10, 2024
lifubang
reviewed
Dec 10, 2024
Vendor the OCI spec with the Network Devices support Signed-off-by: Antonio Ojea <[email protected]>
Implement support for passing Linux Network Devices to the container network namespace. The network device is passed during the creation of the container, before the process is started. It implements the logic defined in the OCI runtime specification. Change-Id: I1306a783b84ead7b03eea679941bd4db9dc1e353 Signed-off-by: Antonio Ojea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft implementation of opencontainers/runtime-spec#1271
It implements the new proposal to the OCI spec to be able to specify Network Devices that get attached/dettached from the containers