calculate sizes on packaging and show in registry UI if available #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new fields in package.json when packaged by OC.
oc.files.template.size: number: size in bytes of the template (including all js files like react-component.js if using older templates).oc.files.dataProvider.size?: number: size in bytes of the server.js (if exists).Then, if at least there is one component in the component list with the size defined, a new column will appear called "Size" that will show the size in kbs of the template. On the info will also show on the properties.
For now I'm not showing the size of the server on the Registry UI as I'm not sure is as valuable, but I'm saving it on package.json just in case I want to add it in the future.