Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_fig() plotting function #3

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

gilbertgong
Copy link
Contributor

@gilbertgong gilbertgong commented Nov 20, 2024

Pull Request

Implement get_fig() per issue 1, generate a Figure object which the user can then browse or write to disk

Description

Uses the code from the examples to implement get_fig()

Also, a default pip install -r requirements.txt resulted in an error, which is fixed by pinning scipy to version 1.8.1

Examples are updated.

Fixes

pins scipy to avoid potential incompatibility with newer versions

How Has This Been Tested?

Ran the example files

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@gilbertgong gilbertgong mentioned this pull request Nov 20, 2024
@peterdudfield
Copy link
Contributor

Thanks so much for doing this, do you mind add a screen shot of what the new plots look like?
Thanks

@gilbertgong
Copy link
Contributor Author

gilbertgong commented Nov 20, 2024

The code is pretty much cut and pasted from the examples (only with changes to using instance variables as appropriate) so they look pretty much exactly the same as before.

image
image

@peterdudfield peterdudfield merged commit 038383f into openclimatefix:main Nov 20, 2024
@peterdudfield
Copy link
Contributor

Thanks for this @gilbertgong

@gilbertgong
Copy link
Contributor Author

I'll try consumption next =D

@peterdudfield
Copy link
Contributor

#4 could be good to fix too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants