Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable bubble size #460

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 24, 2024

Pull Request

Description

Adjust the bubble size depending on the total capacity of all the sites
Have not done #444, so probably best to comment this out for the moment - TODO

Fixes #445

added a few tests too

For a user with only 5 sites goes from (its the same for the ocf group)

Screenshot 2024-01-24 at 19 25 02

to

Screenshot 2024-01-24 at 19 25 07

How Has This Been Tested?

Ran in on vercel, tested out the OCF group and a site group that only has about 5 sites.

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 3:13pm

@peterdudfield peterdudfield changed the base branch from main to development January 24, 2024 19:27
@peterdudfield
Copy link
Contributor Author

Probably ready for @braddf and @rachel-labri-tipton to have a look at. I was going to remove the key too, should it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic largest bubble
1 participant