Issue/get india data #127
Open
Issue/get india data #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…fix/pvoutput into issue/get-india-data
for more information, see https://pre-commit.ci
| date_ranges_to_download = self._filter_date_range( | ||
| output_filename, pv_system_id, date_ranges_to_download, min_data_availability | ||
| ) | ||
| # # How much data is actually available? |
There was a problem hiding this comment.
Might be good to put this back in, and add a comment saying,
if you dont have access to XXX API route, then comment this bit out
Or something like that
|
There's one comment here, @rachel-labri-tipton lets get this merge as well, |
|
Shall we try and get this merged before xmas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR is the work done to get data from pvoutput.org for solar sites in India:
examplesfolder that gets India system metadata (or any country besides AU, US, UK and DE) using the PVOutput.org Get Country System Data Service - WORLD route and stores data in a csv fileget_metadata_for_country, topvoutput.pypvoutput.pyfile so the panda's timezone conversion method is up to dateFixes #124
How Has This Been Tested?
Didn't write any pytests but got the data from PVOutput.org that was requested.
Checklist: