Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update panda time converter #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update panda time converter #125

wants to merge 2 commits into from

Conversation

rachel-labri-tipton
Copy link

@rachel-labri-tipton rachel-labri-tipton commented Oct 25, 2023 •
edited
Loading

Pull Request

Description

Pandas time converter has updated since last this repo was used.

How Has This Been Tested?

Ran the tests for pvoutput.py, which passed.

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

peterdudfield
peterdudfield approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same tests are failling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachel-labri-tipton @peterdudfield @devsjc