179: add-model-to-sites-table #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanaawad24
force-pushed
the
add-model-to-sites-table
branch
5 times, most recently
from
52f7d4c
to
062c8c7
Compare
hanaawad24
force-pushed
the
add-model-to-sites-table
branch
2 times, most recently
from
223948b
to
d42dca6
Compare
|
Thanks so much @hanaawad24 for doing this. I've added this in already - https://github.com/openclimatefix/pv-site-datamodel/blob/main/pvsite_datamodel/write/user_and_site.py#L381 I wondered if you could improve the current function, and include those extra tests you have added? |
| nullable=True, | ||
| comment="The ML Model which should be used for this site", | ||
| ) | ||
| model_uuid = sa.Column(UUID(as_uuid=True), sa.ForeignKey("ml_model.model_uuid")) |
There was a problem hiding this comment.
could you remove this change, the nullable=True, and the comment is useful
|
I'll close this for the moment, but feel free to add those test improvements on this PR, or a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR addresses the issue #179 to handle the ability to assign a model to one or more site.