fetches live Enphase data at the moment it is called #66

aryanbhosale · 2024-02-28T15:16:49Z

replace 'user_enphase_api_key' and 'user_enphase_user_id' with the actual Enphase API key and user ID. The make_pv_data function now fetches live data from the Enphase API and combines it with the existing fake PV data This "may" not be from the time of interference, do i add make use of timestamps to enable it?

Pull Request

Description

I have updated the comments to encapsulate what's updated

Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Yes

Checklist:

My code follows OCF's coding style guidelines
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked my code and corrected any misspellings

replace 'user_enphase_api_key' and 'user_enphase_user_id' with the actual Enphase API key and user ID. The make_pv_data function now fetches live data from the Enphase API and combines it with the existing fake PV data This "may" not be from the time of interference, do i add make use of timestamps to enable it?

codecov · 2024-02-28T15:19:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (b1bb4cd) to head (bdb181b).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files          11       11           
  Lines         334      334           
=======================================
  Hits          270      270           
  Misses         64       64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

peterdudfield · 2024-02-28T16:43:42Z

Thanks so much for this @aryanbhosale . This links with #59.
Did you test this with any real data? I think I can get you some credientials and then we should try it out.

I think it would be good for the user to have an option, to either use live pv data from enphase or not. This would mean that by default it works without this data. This is becasue only some users will have pv data from an enphase inverter

aryanbhosale · 2024-02-28T16:52:19Z

Thanks so much for this @aryanbhosale . This links with #59. Did you test this with any real data? I think I can get you some credientials and then we should try it out.

I think it would be good for the user to have an option, to either use live pv data from enphase or not. This would mean that by default it works without this data. This is becasue only some users will have pv data from an enphase inverter

No @peterdudfield I haven't yet tried it with real data because of the limitation of credentials. But since you can get some credentials to work with, I could do it this week.
I also liked the idea of giving the user an option to choose the default values or the live ones, I will work on implementing that first.
Thank you for the opportunity @peterdudfield !

Now the user will have an option whether to use live enphase data or the default data

aryanbhosale · 2024-02-28T17:23:45Z

Thanks so much for this @aryanbhosale . This links with #59. Did you test this with any real data? I think I can get you some credientials and then we should try it out.

I think it would be good for the user to have an option, to either use live pv data from enphase or not. This would mean that by default it works without this data. This is becasue only some users will have pv data from an enphase inverter

I've made a new PR for giving user an option to choose whether to use enphase live data or the default one

aryanbhosale · 2024-02-29T08:16:50Z

@peterdudfield could you please review my PR for issue #36 and give suggestions on how I could make it better/feature rich
Thank you

quartz_solar_forecast/data.py

…ters/enphase.py file

aryanbhosale · 2024-03-02T19:28:10Z

Hi @peterdudfield , could you please review my code?

peterdudfield · 2024-03-04T07:45:14Z

quartz_solar_forecast/data.py


 ssl._create_default_https_context = ssl._create_unverified_context

+# User needs to add their Enphase API details
+ENPHASE_API_KEY = 'user_enphase_api_key'


could we make this envionrment variables?

could we make this envionrment variables?

Sure, will make the required change and add a .env.example file

could we make this envionrment variables?

Should i add a .env file in /Open-Source-Quartz-Solar-Forecast/quartz_solar_forecast
or simply in /Open-Source-Quartz-Solar-Forecast

could we make this envionrment variables?

I have added the changes in my PR for environment variables, please review it. Thank you

peterdudfield · 2024-03-04T07:46:38Z

One small change, and lets then gets this merged.
Things to add later on would be

test with real enphase details
add example code, on how to use this

aryanbhosale · 2024-03-04T08:56:17Z

One small change, and lets then gets this merged. Things to add later on would be

test with real enphase details

add example code, on how to use this

Will do!

@0xFrama

* Bump version: 1.0.9 → 1.0.10 [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Bump version: 1.0.10 → 1.0.11 [skip ci] * Replace H with h inside pandas' floor function (#64) Thanks @0xFrama for this * Bump version: 1.0.11 → 1.0.12 [skip ci] * Added Contribution Guide (#65) * added contribution guide * added reference to coding style * Bump version: 1.0.12 → 1.0.13 [skip ci] * docs: add roshnaeem as a contributor for doc (#67) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Test set analysis (#60) * test set analysis * added link to nbviewer in notebook * deleted checkpoints * Delete checkpoints * delete metadata.csv * using metadata from hugging face * remove unused import * Bump version: 1.0.13 → 1.0.14 [skip ci] * docs: add bikramb98 as a contributor for code (#68) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * fetches live Enphase data at the moment it is called (#66) * fetches live Enphase data at the moment it is called replace 'user_enphase_api_key' and 'user_enphase_user_id' with the actual Enphase API key and user ID. The make_pv_data function now fetches live data from the Enphase API and combines it with the existing fake PV data This "may" not be from the time of interference, do i add make use of timestamps to enable it? * Added Flag indicating whether to use live Enphase data or not Now the user will have an option whether to use live enphase data or the default data * Updated site object to accomodate is_inverter option + created /inverters/enphase.py file * added environment variables * Bump version: 1.0.14 → 1.0.15 [skip ci] * added init.py in invertors directory * fixed the import of enphase_data --------- Co-authored-by: BumpVersion Action <bumpversion@github-actions> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Peter Dudfield <[email protected]> Co-authored-by: Francesco <[email protected]> Co-authored-by: Bikram Baruah <[email protected]> Co-authored-by: Aryan Bhosale <[email protected]>

@0xFrama

* Bump version: 1.0.9 → 1.0.10 [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Bump version: 1.0.10 → 1.0.11 [skip ci] * Replace H with h inside pandas' floor function (#64) Thanks @0xFrama for this * Bump version: 1.0.11 → 1.0.12 [skip ci] * Added Contribution Guide (#65) * added contribution guide * added reference to coding style * Bump version: 1.0.12 → 1.0.13 [skip ci] * docs: add roshnaeem as a contributor for doc (#67) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- * Test set analysis (#60) * test set analysis * added link to nbviewer in notebook * deleted checkpoints * Delete checkpoints * delete metadata.csv * using metadata from hugging face * remove unused import * Bump version: 1.0.13 → 1.0.14 [skip ci] * docs: add bikramb98 as a contributor for code (#68) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- * fetches live Enphase data at the moment it is called (#66) * fetches live Enphase data at the moment it is called replace 'user_enphase_api_key' and 'user_enphase_user_id' with the actual Enphase API key and user ID. The make_pv_data function now fetches live data from the Enphase API and combines it with the existing fake PV data This "may" not be from the time of interference, do i add make use of timestamps to enable it? * Added Flag indicating whether to use live Enphase data or not Now the user will have an option whether to use live enphase data or the default data * Updated site object to accomodate is_inverter option + created /inverters/enphase.py file * added environment variables * Bump version: 1.0.14 → 1.0.15 [skip ci] * added init.py in invertors directory * fixed the import of enphase_data --------- Co-authored-by: Rosheen Naeem <[email protected]> Co-authored-by: BumpVersion Action <bumpversion@github-actions> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Francesco <[email protected]> Co-authored-by: Bikram Baruah <[email protected]> Co-authored-by: Aryan Bhosale <[email protected]>

aryanbhosale · 2024-03-28T21:24:11Z

Hi @peterdudfield ,what are the next steps for this project? I would like to dive deeper and solve more issues on this topic

Added Flag indicating whether to use live Enphase data or not

da373c5

Now the user will have an option whether to use live enphase data or the default data

peterdudfield reviewed Feb 29, 2024

View reviewed changes

quartz_solar_forecast/data.py Outdated Show resolved Hide resolved

peterdudfield reviewed Feb 29, 2024

View reviewed changes

quartz_solar_forecast/data.py Outdated Show resolved Hide resolved

aryanbhosale and others added 2 commits March 1, 2024 16:56

Merge branch 'openclimatefix:main' into patch-2

8e3be11

Updated site object to accomodate is_inverter option + created /inver…

4285935

…ters/enphase.py file

aryanbhosale mentioned this pull request Mar 3, 2024

Adjust for capacity #3

Open

peterdudfield reviewed Mar 4, 2024

View reviewed changes

added environment variables

bdb181b

peterdudfield mentioned this pull request Mar 4, 2024

Project GSoC: Solar Panel Inverter data #59

Closed

peterdudfield approved these changes Mar 4, 2024

View reviewed changes

peterdudfield merged commit 6a09e4c into openclimatefix:main Mar 4, 2024
4 checks passed

peterdudfield mentioned this pull request Mar 4, 2024

Fix tests #70

Closed

peterdudfield mentioned this pull request Mar 4, 2024

Added init.py for CI tests (#71) #72

Merged

This was referenced Apr 13, 2024

updated enphase api to v4 #106

Merged

Next Steps with Enphase Inverter #107

Closed

add implementation of giving it live pv data #47

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fetches live Enphase data at the moment it is called #66

fetches live Enphase data at the moment it is called #66

aryanbhosale commented Feb 28, 2024 •

edited

Loading

codecov bot commented Feb 28, 2024 •

edited

Loading

peterdudfield commented Feb 28, 2024

aryanbhosale commented Feb 28, 2024

aryanbhosale commented Feb 28, 2024

aryanbhosale commented Feb 29, 2024 •

edited

Loading

aryanbhosale commented Mar 2, 2024

peterdudfield Mar 4, 2024

aryanbhosale Mar 4, 2024

aryanbhosale Mar 4, 2024

aryanbhosale Mar 4, 2024

peterdudfield commented Mar 4, 2024

aryanbhosale commented Mar 4, 2024

aryanbhosale commented Mar 28, 2024

fetches live Enphase data at the moment it is called #66

fetches live Enphase data at the moment it is called #66

Conversation

aryanbhosale commented Feb 28, 2024 • edited Loading

Pull Request

Description

How Has This Been Tested?

Checklist:

codecov bot commented Feb 28, 2024 • edited Loading

Codecov Report

peterdudfield commented Feb 28, 2024

aryanbhosale commented Feb 28, 2024

aryanbhosale commented Feb 28, 2024

aryanbhosale commented Feb 29, 2024 • edited Loading

aryanbhosale commented Mar 2, 2024

peterdudfield Mar 4, 2024

Choose a reason for hiding this comment

aryanbhosale Mar 4, 2024

Choose a reason for hiding this comment

aryanbhosale Mar 4, 2024

Choose a reason for hiding this comment

aryanbhosale Mar 4, 2024

Choose a reason for hiding this comment

peterdudfield commented Mar 4, 2024

aryanbhosale commented Mar 4, 2024

aryanbhosale commented Mar 28, 2024

aryanbhosale commented Feb 28, 2024 •

edited

Loading

codecov bot commented Feb 28, 2024 •

edited

Loading

aryanbhosale commented Feb 29, 2024 •

edited

Loading