Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified the steps in Readme file #208

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

sumana-2705
Copy link
Contributor

Description

Fixes #204

  • Simplified the instruction to run the forecast_csv.py script in the main README for better clarity.
  • Changed the instruction from navigating to the scripts directory and then running the script to a single command.

@peterdudfield
Copy link
Contributor

Thank you for this. Would you be able to add a file back in to scripts/forecast_csv.py

it would be copying this out to this serepate file

@sumana-2705
Copy link
Contributor Author

Okay, I'll add the file. Thank you

@peterdudfield
Copy link
Contributor

Hi @sumana-2705.

Sorry i might have confused you.
I would prefer the main code to stay in the library and the script just to have

if __name__ == "__main__":
    # please change the site name, start_datetime and end_datetime, latitude, longitude and capacity_kwp as per your requirement
    write_out_forecasts(
        init_time_freq=6,
        start_datetime="2024-03-10 00:00:00",
        end_datetime="2024-03-11 00:00:00",
        site_name="Test",
        latitude=51.75,
        longitude=-1.25,
        capacity_kwp=1.25
    )

@sumana-2705
Copy link
Contributor Author

I'm sorry @peterdudfield, I was confused a little. I hope this commit has done required changes

@peterdudfield
Copy link
Contributor

and can you remove if name == "main": e.t.c from here

@peterdudfield peterdudfield merged commit 98f9dd3 into openclimatefix:main Oct 25, 2024
1 of 2 checks passed
@peterdudfield
Copy link
Contributor

thanks @sumana-2705, @all-contributors please add @sumana-2705 for code

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @sumana-2705! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidy up readme example
2 participants