Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save batch #141

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Save batch #141

wants to merge 8 commits into from
+60 −5

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 26, 2024 •
edited
Loading

Pull Request

Description

An option to save batches
#114

How Has This Been Tested?

Ci tests
new test
ran locally

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 26, 2024 16:37
@Sukh-P
Copy link
Member

Sukh-P commented Nov 26, 2024 •
edited
Loading

Has this been tested yet in terms of saving the batch to an S3 bucket (or wherever these would be saved to)? Or have the tests been to save locally?

@peterdudfield
Copy link
Contributor Author

Has this been tested yet in terms of saving the batch to an S3 bucket (or wherever these would be saved to)? Or have the tests been to save locally?

test is to save locally, but i can test to s3 to double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Awaiting requested review from Sukh-P

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P