Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/model names #98

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Issue/model names #98

merged 3 commits into from
Nov 13, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 13, 2024 •
edited
Loading

Pull Request

Description

  • hard code model names for now
  • updated tests

#97

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield merged commit 1bb40b8 into main Nov 13, 2024
8 checks passed
@peterdudfield peterdudfield deleted the issue/model-names branch November 13, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc