Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More small screen responsiveness #1160

Merged
merged 13 commits into from
Dec 9, 2024
Merged

More small screen responsiveness #1160

merged 13 commits into from
Dec 9, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Sep 26, 2023 •
edited
Loading

Makes the editors appearance on narrow screens a little more palatable. This PR is not intended to make the editor fully usable in portrait mode, but rather help users with narrow screens and/or high zoom levels to get a little more out of their screen space.

Only touches the header, main menu, cutting view and metadata view for now.

Resolves #23, maybe?

@Arnei
Avoid cutting actions row overflowing
eb595f8 
Have it wrap instead, or just drop the text altogether
@Arnei
Reduce video controls row minwidth
f153909 
If we start lacking in available maxWidth, dont show some
stuff to avoid overflow.
@Arnei
Improve Header for small screen widths
7d12e82 
The header can now get even narrower, like in Studio.
@Arnei
Reduce main menu min width
60939d9 
On narrow resolutions, the main menu takes up *a lot*
of space. Now it takes less than half of what it took
before.
@Arnei
More space for metadata on narrow screens
07127a3 
There's quite a lot of empty space in the metadata view.
It feels especially bad when you don't have a lot of screen
real estate in the first place, so let's use a little more of
it.
@Arnei Arnei added type:visual-clarity A part of the UI is not visually readable type:usability Usability improvements labels Sep 26, 2023
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1160/2023-09-26_15-02-56/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This pull request is deployed at test.editor.opencast.org/1160/2023-10-05_10-28-40/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Oct 31, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

This pull request is deployed at test.editor.opencast.org/1160/2023-11-01_09-11-33/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Jan 18, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Jan 18, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1160/2024-01-18_15-14-02/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Mar 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@KatrinIhler
Copy link
Member

Conflicts :(

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label May 13, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1160/2024-05-13_13-00-25/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Jun 21, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Jun 21, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1160/2024-06-21_10-41-05/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

This pull request is deployed at test.editor.opencast.org/1160/2024-07-03_08-20-55/ .
It might take a few minutes for it to become available.

@Arnei Arnei mentioned this pull request Jul 11, 2024
Open
@geichelberger geichelberger self-assigned this Dec 5, 2024
geichelberger
geichelberger requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@geichelberger geichelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the not-used value.

src/main/Header.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

This pull request is deployed at test.editor.opencast.org/1160/2024-12-06_08-39-26/ .
It might take a few minutes for it to become available.

geichelberger
geichelberger approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@geichelberger geichelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geichelberger geichelberger merged commit ef8aec1 into opencast:main Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geichelberger geichelberger geichelberger approved these changes

Assignees

@geichelberger geichelberger

Labels
type:usability Usability improvements type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non Breaking Cutting Tools
3 participants
@Arnei @KatrinIhler @geichelberger