-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow series path removal via Tobira tab in series details #983
Conversation
I introduced said error with a previous fix for another bug...
Also adds some padding for lenghtier texts in the modal.
This should help to more accurately distinguish the editing of existing paths and the mounting previously unmounted series (either when creating a series or working on a series that just wasn't mounted when originally created). These cases need slightly different texts.
Also simplifies some markup of the Tobira path table and introduces the use of icon buttons for editing and removing paths (instead of link-styled "text" buttons).
This pull request is deployed at test.admin-interface.opencast.org/983/2024-11-19_15-21-28/ . |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and looks reasonable to me.
I changed the mount endpoint in opencast, so now this uses a dedicated endpoint each for mounting and unmounting.
This pull request is deployed at test.admin-interface.opencast.org/983/2024-12-10_21-34-56/ . |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
I split up the series endpoint in opencast/opencast#6317. There is now a dedicated endpoint for removing the path, and my latest push here utilizes that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I open a series details tab like the above, close it, then open the series details tab of another series, the series details tab of that other series will also look like above, even if it normally wouldn't. This can only be fixed with a page reload.
Furthermore, it seems I cannot update a series path anymore. The web request to do so fails with a 400.
Request:
http://localhost:3000/admin-ng/series/84e3ddbf-c799-41ac-83b5-22e2e4b23e8f/tobira/path
{
"pathComponents": "[{\"name\":\"uiuiui\",\"pathSegment\":\"uiuiui\"}]",
"targetPath": "/uiuiui"
}
The other thing should be fixed with my latest push of opencast/opencast#6317. Please don't look at the diff. It's really stupid. |
Ok, I did just manage to reproduce the first issue.
The Tobira thing should be an easy enough fix, but that still leaves the other issue. |
This will basically just reset any Tobira errors when opening a new series details modal, and remove any notifications when closing series modals.
Alright, the error should be fixed now. Some background information: The issue you noticed when opening another details modal of a series already known to Tobira was happening because the error and notification were not reset when closing a modal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues have been fixed, lgtm.
This modifies the UI from #878 to include the option to remove a series path in Tobira ("unmounting").
Needs opencast/opencast#6317 to work.
Also fixes a minor bug and introduces icon buttons for the series path editing (see screenshots):