Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Set Filter Profile dialog behavior and styles #659

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ferishili
Copy link
Contributor

This PR fixes #618,

As it is stated in issue, this wizard/dialog doesn't behave as it should specially when clicking cancel button (it closes the dialog and in edit mode removes the profile) => that is no go!

This PR fixes this bad behavior by bringing the currentlyEditing variable to live once again and set its type as FilterProfile or null. So on cancelEditProfile we now only check if it was in editing mode and create a record of that instead of letting it be removed for good!

NOTE: A new translation key under "TABLE_FILTERS > PROFILES > ADD" is added. which replace the save text on the button when in adding new profile mode!

Apart from that, the style of the form in add/edit mode gets a proper look now!

@ferishili ferishili added type:bug Something isn't working type:visual-clarity Improves UI readability type:usability Improves the UX bugbash labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/659/2024-06-06_13-19-23/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-659

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-659

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg ziegenberg removed type:bug Something isn't working type:visual-clarity Improves UI readability labels Jun 5, 2024
@Arnei
Copy link
Member

Arnei commented Jun 6, 2024

I can get a saved filter to be displayed in the list anymore, if i close the edit menu with the x button:
Bildschirmaufzeichnung vom 2024-06-06, 14-01-34.webm

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised and code looks good to me too. Just found the one thing in the comment above.

@ferishili
Copy link
Contributor Author

Thanks, I will fix it. That faulty behavior was meant to be fixed as well.

@ferishili ferishili requested a review from Arnei June 6, 2024 13:19
@Arnei Arnei merged commit d3f93fc into opencast:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Improves the UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve saved filters dialog
3 participants