Fix Set Filter Profile dialog behavior and styles #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #618,
As it is stated in issue, this wizard/dialog doesn't behave as it should specially when clicking cancel button (it closes the dialog and in edit mode removes the profile) => that is no go!
This PR fixes this bad behavior by bringing the
currentlyEditing
variable to live once again and set its type asFilterProfile
or null. So oncancelEditProfile
we now only check if it was in editing mode and create a record of that instead of letting it be removed for good!NOTE: A new translation key under "TABLE_FILTERS > PROFILES > ADD" is added. which replace the save text on the button when in adding new profile mode!
Apart from that, the style of the form in add/edit mode gets a proper look now!