Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing the hamburger menu icon color to have a better contrast ratio #645

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

rlucke
Copy link
Contributor

@rlucke rlucke commented Jun 5, 2024

changing the hamburger menu icon color to have a better contrast ratio

fix #630

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Hi @rlucke
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

EDIT(@lkiesow): The ICLA has been filed. Thanks. It may take some time for Apereo to process the ICLA. Feel free to ignore this complaint for now and point others to this comment if anyone asks.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/645/2024-06-05_13-22-44/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-645

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-645

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@rlucke rlucke added the type:accessibility This would help impaired users label Jun 5, 2024
@lkiesow
Copy link
Member

lkiesow commented Jun 5, 2024

Hi @rlucke,
can you please give your pull requests a title and a short description which explains what they do? Not having that makes it really hard to search for issues, makes quickly finding out what a pull request is about harder, and is annoying if you want to do a review since the linked issues don't necessarily explain the way you fixed an issue.

@rlucke
Copy link
Contributor Author

rlucke commented Jun 5, 2024

Can someone explain to me why Check ICLA goes wrong?

@ferishili
Copy link
Contributor

Can someone explain to me why Check ICLA goes wrong?

It might take sometimes (up to 1 day) for the record to be added into relative tables!

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Hi @rlucke
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@rlucke rlucke changed the title fix #630 changing the hamburger menu icon color to have a better contrast ratio Jun 6, 2024
@lkiesow lkiesow self-assigned this Jun 7, 2024
@lkiesow lkiesow merged commit 3cbbaa3 into opencast:main Jun 7, 2024
5 of 7 checks passed
@rlucke rlucke deleted the issue-630 branch June 12, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:accessibility This would help impaired users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hamburger menu icon contrast
4 participants