-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce minimum column width #588
Enforce minimum column width #588
Conversation
…ing. Some languages could go lower here, but our longest one (DE) needs 79 px. Rounded up to 80 since round numbers are better. Fixes opencast#450
This pull request is deployed at test.admin-interface.opencast.org/588/2024-06-05_16-05-29/ . |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to make this safe with even longer translations?
I came up with the 80 value by expanding things until (i thought...) nothing dropped. Honestly not sure how to make the minimum auto set - I'm guessing we need to check all the languages, find the longest, and then add a bit extra? |
Bringing that value up to 150(!) gets you no more dropping sorts, but in the case where the window width is smaller than The minimum window size that triggers this is 1490px, which is... not that small. Unclear what the correct course of action is here. It looks goofy to have the page do this, but the dropping sorters also look silly. |
…ther issues. See opencast#588 for details.
@ziegenberg is fixing the translations, but they're not done yet. Putting this to draft until I've had a chance to test with the full set of translations. |
Conclusion on 2024-06-25 was that fixing this right is out of scope. Something about rewriting things in flexbox? Iunno, not a front end guy :) |
This PR enforces a minimum column width to prevent the sorting arrow from dropping down a line.
Fixes #450