Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discernible text to prev/next pagination buttons. #553

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Add discernible text to prev/next pagination buttons. #553

merged 3 commits into from
Jun 5, 2024
+8 −2

Conversation

luniki
Copy link
Contributor

@luniki luniki commented Jun 4, 2024

Fixes #529

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Hi @luniki
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-553

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-553

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg ziegenberg added the type:accessibility This would help impaired users label Jun 4, 2024
@ziegenberg
Copy link
Member

Hi @luniki,

the build failed. Could you have a look and fix the errors.

@ziegenberg ziegenberg self-requested a review June 4, 2024 11:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/553/2024-06-04_11-37-32/ .
It might take a few minutes for it to become available.

ziegenberg
ziegenberg requested changes Jun 4, 2024
View reviewed changes
src/components/shared/Table.tsx Outdated
@@ -336,7 +336,9 @@ const Table = ({
<button
className={"button-like-anchor " + cn("prev", { disabled: !isNavigatePrevious() })}
onClick={() => goToPage(pageOffset - 1)}
/>
>
<span className="sr-only">{t("EVENTS.EVENTS.TABLE.PREVIOUS")}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find where the lang string EVENTS.EVENTS.TABLE.PREVIOUS is in use anywhere else.

As EVENTS.EVENTS.TABLE.* is specific to the events table, and as src/components/shared/Table.tsx is shared between all tables, I suggest moving the PREVIOUS and NEXT lang string to the top level, maybe next to TABLE_NO_RESULT or TABLE_LOADING.

Could you make the neccessaray changes in src/i18n/org/opencastproject/adminui/languages/lang-en_US.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sure.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/553/2024-06-05_03-47-12/ .
It might take a few minutes for it to become available.

@ziegenberg ziegenberg merged commit 0e402a1 into opencast:main Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziegenberg ziegenberg ziegenberg approved these changes

Assignees
No one assigned
Labels
type:accessibility This would help impaired users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination buttons must have discernible text
2 participants
@luniki @ziegenberg