Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CI=true in all workflows #496

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented May 31, 2024

As all the warnings on the build are now fixed (thx to #430), we no longer need to set CI=false to actively suppress warnings to be picked up by our CI tests. This should help with us not introducing new warnings.

As all the warnings on the build are now fixed (thx to opencast#430), we no
longer need to set `CI=false` to actively suppress warnings to be
picked up by our CI tests. This should help with us not introducing new
warnings.
@lkiesow lkiesow added the type:tests Unit and integration tests label May 31, 2024
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/496/2024-05-31_10-35-36/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-496

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-496

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@ziegenberg ziegenberg merged commit 2f6c472 into opencast:main Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:tests Unit and integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants