Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct source for container image #492

Merged
merged 1 commit into from
May 31, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented May 30, 2024

The workflow for building the test container images is triggered by pull_request_target which means that we explicitly need to state that we want to check out the pull request source code and not what is already in the repository.

The workflow for building the test container images is triggered by
`pull_request_target` which means that we explicitly need to state
that we want to check out the pull request source code and not what is
already in the repository.
Copy link
Contributor

Use docker or podman to test this pull request locally.

Local test with mock data

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-492

Proxy data from develop.opencast.org

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://develop.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-492

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@lkiesow
Copy link
Member Author

lkiesow commented May 31, 2024

Thanks for reviewing this, @Arnei. I'm merging this since this may cause people to test incorrect code otherwise. That could have bad side effects especially when the BugBash starts on Tuesday.

@lkiesow lkiesow merged commit 1726a51 into opencast:main May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants