Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superflous SCSS for old video editor #460

Merged
merged 1 commit into from
May 30, 2024

Conversation

ziegenberg
Copy link
Member

@ziegenberg ziegenberg commented May 24, 2024

The new standalone editor replaced the integrated editor, and these styles are no longer needed. Only the .video-player class was used again for media asset video preview and required to stay.

@ziegenberg ziegenberg added the type:code-enhancement Internal improvements to the codebase label May 24, 2024
@ziegenberg ziegenberg marked this pull request as draft May 28, 2024 16:33
@ziegenberg ziegenberg force-pushed the remove-video-editor-scss branch from fb747f5 to 1662e6c Compare May 29, 2024 12:00
Copy link
Contributor

Use docker or podman to test this pull request locally.

Local test with mock data

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-460

Proxy data from develop.opencast.org

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://develop.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-460

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg ziegenberg force-pushed the remove-video-editor-scss branch from 1662e6c to 7f8d4b2 Compare May 29, 2024 12:09
@ziegenberg ziegenberg marked this pull request as ready for review May 29, 2024 12:10
@ziegenberg
Copy link
Member Author

@Arnei I rebased and amended my commit slightly. Only the .video-player class was used again for the media asset video preview and required to stay. Can you have another look at it?

@ziegenberg ziegenberg force-pushed the remove-video-editor-scss branch from 7f8d4b2 to 7b1f6b8 Compare May 29, 2024 12:41
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked on everything I could think of, can confirm that the media asset video preview is working.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

The new standalone editor replaced the integrated editor and this styles
are no longer needed. Only the .video-player class was used again for
media asset video preview and needs to stay.

Signed-off-by: Daniel Ziegenberg <[email protected]>
@ziegenberg ziegenberg force-pushed the remove-video-editor-scss branch from 7b1f6b8 to 11b8e4e Compare May 30, 2024 13:47
@ziegenberg ziegenberg merged commit 6fd4155 into opencast:main May 30, 2024
2 of 3 checks passed
@ziegenberg ziegenberg deleted the remove-video-editor-scss branch May 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants