Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on warnings when building releases #349

Merged
merged 1 commit into from
May 30, 2024
Merged

Fail on warnings when building releases #349

merged 1 commit into from
May 30, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented May 6, 2024

This patch removes the forced CI=false which means that the build process will fail on compiler warnings.

@lkiesow
Fail on warnings when building releases
97485ad 
This patch removes the forced `CI=false` which means that the build
process will fail on compiler warnings.
@gregorydlogan gregorydlogan marked this pull request as draft May 7, 2024 16:08
@ziegenberg
Copy link
Member

@lkiesow As all the warnings on the build are now fixed (thx to #430) I think we can now merge this.

@ziegenberg ziegenberg marked this pull request as ready for review May 30, 2024 14:38
@ziegenberg ziegenberg added the type:infrastructure Build process, deployment, workflows label May 30, 2024
@ziegenberg ziegenberg self-assigned this May 30, 2024
@ziegenberg ziegenberg merged commit e29378e into opencast:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziegenberg ziegenberg ziegenberg approved these changes

Assignees

@ziegenberg ziegenberg

Labels
type:infrastructure Build process, deployment, workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkiesow @ziegenberg