Respect config option for adding series ACL to new event #321

Arnei · 2024-04-05T12:43:49Z

The backend configuration file org.opencastproject.organization-mh_default_org.cfg has a config option called admin.init.event.acl.with.series.acl. It determines whether the ACL of a new event is initialized with the ACL of its series, and true per default. We were not respecting this config option at all. This PR changes that.

The backend configuration file `org.opencastproject.organization-mh_default_org.cfg` has a config option called `admin.init.event.acl.with.series.acl`. It determines whether the ACL of a new event is initialized with the ACL of its series, and true per default. We were not respecting this config option at all. This PR changes that.

Arnei · 2024-04-05T12:44:45Z

@mwuttke from my understanding this should fix #316 (for real this time), but I don't have a Moodle around to test it.

mwuttke · 2024-04-08T06:09:47Z

@Arnei, thanks for the hint. Please coud you explain me how I can test this patch respectively how can I build the opencast-admin-interface jar file by my self? I was not able to compile it with the build-release.sh script. There were some error messages.

Arnei · 2024-04-08T06:57:49Z

Did you maybe not run the script from the .github folder? Otherwise could you post the logs?

For quick testing, I basically do what is described in the "Quickstart" section of the project ReadMe. But instead of running the proxy server against http://stable.opencast.org I run it against my own Opencast.
Alternatively, i follow "How to cut a release for Opencast", but push the tag to my own fork of this repo to create the release on my fork (and don't actually submit a pull request, just change the interface.url in the pom.xml).

mwuttke · 2024-04-08T07:54:16Z

@Arnei, thank you for your explanations. But it would be easiest for me to test your PR if I had a step-by-step guide on how to create a corresponding jar file for opencast-admin-interface to store it in our opencast test system (version 15.3). I was not able to run the proxy server against our test system.

mwuttke · 2024-04-09T16:33:13Z

Now I am able to run the proxy server against our test system. The node.js & npm version on the local host was to old. ;-)
But now the proxy-server allways crashs at the same point: When I try to configure "Schedule multiple events" and try to select a workflow the proxy-server crashs reproducible, as it does not find any workflows. So I am not able to test your patch to see if the ACLs of the series are set correctly. I am sorry.

Arnei · 2024-04-10T07:08:30Z

Thanks for trying to test anyway, and sorry for not getting back to you on more detailed steps on how to test.

As for the proxy server crashing on workflow selection, I cannot reproduce that even if I intentionally configure no workflows to be available. Might be worth a new bug report issue?

mwuttke · 2024-04-10T08:39:35Z

With the correctly compiled jar file for the opencast-admin-ui-interface this patch works for us. Thanks @Arnei for your help.

mwuttke · 2024-04-11T07:17:15Z

One more addition to the PR: If you create a new event with a series - e.g. for a Moodle course - in our understanding, only the roles of the series should appear in the Access policy tab plus ROLE_GROUP_MH_DEFAULT_ORG_EXTERNAL_APPLICATIONS and ROLE_ADMIN, each with the corresponding read and write permissions.
Please see the difference between the old Admin UI:

and the new Admin UI:

Previously we were combining existing roles with the series roles. But apparently the series roles should just overwrite all other roles. This changes it to that.

KatrinIhler

Works in one direction, but not in the other for me:

When turning off the initialization with the series ACL in Opencast, the ACL tab still shows the roles of the series on event creation even after reloading the page. In that case, only the role of the current user should be shown.

github-actions · 2024-05-03T20:08:29Z

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Arnei · 2024-05-27T07:26:14Z

Sorry @mwuttke, but I am unable to reproduce your problem without a Moodle instance of my own. If I create an event in the admin UI, ROLE_USER_[...] is correctly overwritten by the series roles, meaning it does not appear in the ui.

Arnei · 2024-05-27T07:27:46Z

@KatrinIhler , I am also unable to reproduce your problem. After turning off initialization with series ACL, only the role of the current users is shown to me, so for me it is working as you expected.

KatrinIhler · 2024-05-27T17:17:17Z

Tried to test this again but can't pick a series for a new event (or edit any other metadata field after the title). u_u I'm using Firefox, neither the proxy nor the static data works. In the console I have

Warning: Failed prop type: Invalid prop `connector` of type `boolean` supplied to `ForwardRef(Stepper)`, expected a single ReactElement.
Stepper@http://localhost:3000/admin-ui/static/js/bundle.js:97425:82
WizardStepperEvent@http://localhost:3000/admin-ui/static/js/bundle.js:45902:28
Formik@http://localhost:3000/admin-ui/static/js/bundle.js:158455:28
NewEventWizard@http://localhost:3000/admin-ui/static/js/bundle.js:33479:24
section
NewResourceModal@http://localhost:3000/admin-ui/static/js/bundle.js:38331:26
section
Events@http://localhost:3000/admin-ui/static/js/bundle.js:12379:16
ConnectFunction@http://localhost:3000/admin-ui/static/js/bundle.js:223383:68
RenderedRoute@http://localhost:3000/admin-ui/static/js/bundle.js:227662:7
Routes@http://localhost:3000/admin-ui/static/js/bundle.js:228352:7
Router@http://localhost:3000/admin-ui/static/js/bundle.js:228291:7
HashRouter@http://localhost:3000/admin-ui/static/js/bundle.js:226303:7
App@http://localhost:3000/admin-ui/static/js/bundle.js:8377:75
BoundHotkeysProxyProviderProvider@http://localhost:3000/admin-ui/static/js/bundle.js:222573:19
HotkeysProvider@http://localhost:3000/admin-ui/static/js/bundle.js:222603:31
LocalizationProvider@http://localhost:3000/admin-ui/static/js/bundle.js:113760:9
ThemeProvider@http://localhost:3000/admin-ui/static/js/bundle.js:101927:7
ThemeProvider@http://localhost:3000/admin-ui/static/js/bundle.js:103119:7
ThemeProvider@http://localhost:3000/admin-ui/static/js/bundle.js:100507:9
PersistGate@http://localhost:3000/admin-ui/static/js/bundle.js:239570:20
Provider@http://localhost:3000/admin-ui/static/js/bundle.js:223125:15

which may or may not be related?

Arnei · 2024-05-28T07:31:07Z

That was caused by another PR, should be fixed now.

mwuttke · 2024-06-04T08:47:06Z

That was caused by another PR, should be fixed now.

By which PR this issue is fixed?

Arnei · 2024-06-04T09:42:06Z

I thiiiink this one #309. To be clear, I was specifically referring to the issue Katrin was having.

mwuttke · 2024-06-04T09:45:01Z

I know. Is there anything I can test right now?

Arnei · 2024-06-04T09:55:26Z

Probably not. I have done nothing to fix the issue with Moodle you mentioned, so I don't think that is fixed.

KatrinIhler

Works now, don't know what my earlier problem was. Can't speak to whether this fixes Michael's problem, though.

Arnei added the type:bug Something isn't working label Apr 5, 2024

Overwrite new event ACL with series ACL

0f225f7

Previously we were combining existing roles with the series roles. But apparently the series roles should just overwrite all other roles. This changes it to that.

KatrinIhler requested changes Apr 26, 2024

View reviewed changes

github-actions bot added the status:conflicts label May 3, 2024

Merge branch 'main' into add-series-acl-to-event-config-option

a6ad934

github-actions bot removed the status:conflicts label May 23, 2024

Merge branch 'main' into add-series-acl-to-event-config-option

97c7491

Merge branch 'main' into add-series-acl-to-event-config-option

57fc782

KatrinIhler approved these changes Jun 14, 2024

View reviewed changes

KatrinIhler merged commit 3580cd9 into opencast:main Jun 14, 2024
2 checks passed

mwuttke mentioned this pull request Jul 18, 2024

ACLs of a series (of a Moodle course) are not set by using schedule-and-upload workflow #316

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Respect config option for adding series ACL to new event #321

Respect config option for adding series ACL to new event #321

Arnei commented Apr 5, 2024

Arnei commented Apr 5, 2024

mwuttke commented Apr 8, 2024 •

edited

Loading

Arnei commented Apr 8, 2024

mwuttke commented Apr 8, 2024

mwuttke commented Apr 9, 2024 •

edited

Loading

Arnei commented Apr 10, 2024

mwuttke commented Apr 10, 2024

mwuttke commented Apr 11, 2024 •

edited

Loading

KatrinIhler left a comment

github-actions bot commented May 3, 2024

Arnei commented May 27, 2024

Arnei commented May 27, 2024

KatrinIhler commented May 27, 2024

Arnei commented May 28, 2024

mwuttke commented Jun 4, 2024

Arnei commented Jun 4, 2024 •

edited

Loading

mwuttke commented Jun 4, 2024

Arnei commented Jun 4, 2024

KatrinIhler left a comment

Respect config option for adding series ACL to new event #321

Respect config option for adding series ACL to new event #321

Conversation

Arnei commented Apr 5, 2024

Arnei commented Apr 5, 2024

mwuttke commented Apr 8, 2024 • edited Loading

Arnei commented Apr 8, 2024

mwuttke commented Apr 8, 2024

mwuttke commented Apr 9, 2024 • edited Loading

Arnei commented Apr 10, 2024

mwuttke commented Apr 10, 2024

mwuttke commented Apr 11, 2024 • edited Loading

KatrinIhler left a comment

Choose a reason for hiding this comment

github-actions bot commented May 3, 2024

Arnei commented May 27, 2024

Arnei commented May 27, 2024

KatrinIhler commented May 27, 2024

Arnei commented May 28, 2024

mwuttke commented Jun 4, 2024

Arnei commented Jun 4, 2024 • edited Loading

mwuttke commented Jun 4, 2024

Arnei commented Jun 4, 2024

KatrinIhler left a comment

Choose a reason for hiding this comment

mwuttke commented Apr 8, 2024 •

edited

Loading

mwuttke commented Apr 9, 2024 •

edited

Loading

mwuttke commented Apr 11, 2024 •

edited

Loading

Arnei commented Jun 4, 2024 •

edited

Loading