Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabbing in event details metadata #288

Merged
merged 7 commits into from
May 24, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Feb 9, 2024

In the event/series details metadata tab, it was not possible to navigate between the different items using the "tab" key. This is now possible.

Fixes #233.

In the event/series details metadata tab, it was not
possible to navigate between the different items
using the "tab" key. This is now possible.
@Arnei Arnei added type:bug Something isn't working type:enhancement New feature or request labels Feb 9, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Member

@KatrinIhler KatrinIhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this isn't working for me. I'm testing in Firefox with a proxy against stable.opencast.org. When creating new series or events, I can edit the title, but then no other metadata field can be edited, neither with tabbing nor with clicking into the field or clicking on the little edit icon on the right of the field. Also the metadata of existing events doesn't seem to be editable anymore as well. :(

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@gregorydlogan
Copy link
Member

This seems to work correctly for me now.

@gregorydlogan gregorydlogan merged commit 8717861 into opencast:main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab index not working/existing?
3 participants