Update bourbon from 4 to 7 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the bourbon files in the vendor folder, and instead installs the corresponding npm packages. This has the upside of centralizing our dependencies and avoid hassling around with ruby gems. Unfortunately, it also has the downside of requiring relative paths to the bourbon node modules.
Bourbon version is severly outdated. This updates to the latest version, and also replaces deprecated mixins with native browser CSS. Also requires updating bourbon-neat, which also required updating deprecated mixins. As there was no migration guide for neat this purely a best effort guess based on their documentation and source code.
narickmann
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bourbon version is severly outdated. This updates to the
latest version, and also replaces deprecated mixins with
native browser CSS.
Also requires updating bourbon-neat, which also required
updating deprecated mixins. As there was no migration
guide for neat this purely a best effort guess based on their
documentation and source code.
Includes #201.