Add typescript capabilities #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
TS-Migrate did not run flawlessly. This cleans up any errors it created, as well as a few existing inconsistencies that only now turned up.
|
This pull request has conflicts ☹ |
Missed these in the last merge. Thanks to @owi92
owi92
approved these changes
Sep 26, 2023
|
Thanks for the review, merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses ts-migrate to add typescript to the app part of the project.
To clarify, this PR only introduces typescript to the application, it does not actually make an effort to properly type components. Thus, components are implicitly typed or still
any. However, this PR provides the groundwork for introducing proper typing, which can happen bit by bit in follow-up PRs and new PRs.This PR adds A LOT of lines mainly due to comments disabling typescript errors, most of which complain about implicit
anys. I personally think it's a waste of time to add explicitanys everywhere, as hopefully proper typing will come later, so I'm in favor of leaving the comments in for now.