Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "invalid scale configuration" error and more #1003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Dec 2, 2024

Fixes #282.

The statistics page (and statistics tab in the event and series details) is currently broken. The web console shows the error "Invalid scale configuration for scale: XAxes".

This fixes the error and a few less critical bugs to get the statistics page up and running again.

Unfortunately, testing this is not straightforward. To thoroughly test this, you would need an Opencast with a statistics provider set up and configured, which is more difficult than it sounds. The interested may check the docs: https://docs.opencast.org/develop/admin/#configuration/admin-ui/statistics/

The statistics page (and statistics tab in the event
and series details) is currently broken. The web
console shows the error "Invalid scale configuration
for scale: XAxes".

This fixes the error and a few less critical bugs to
get the statistics page up and running again.
@Arnei Arnei added the type:bug Something isn't working label Dec 2, 2024
@Arnei Arnei requested a review from snoesberger December 2, 2024 15:03
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1003

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1003

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request is deployed at test.admin-interface.opencast.org/1003/2024-12-02_15-03-46/ .
It might take a few minutes for it to become available.

Copy link

@snoesberger snoesberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! I have tested this PR with statistics data from our test system and the display of graphs, download etc. works as expected. The code changes look reasonable to me (and are certainly an improvement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statistics Bug in the new AdminUI
2 participants